Re: [Maria-developers] c29706f: MDEV-17286 Decimal field multiplication bug.
![](https://secure.gravatar.com/avatar/39b623a1559cf9c69ac3d9d4fb44e7fe.jpg?s=120&d=mm&r=g)
30 Oct
2018
30 Oct
'18
12:57 p.m.
Hi, Alexey! On Oct 30, Alexey Botchkov wrote:
What if both arguments will be zeros, but have intg=DIG_PER_DEC1-1. Won't the result have more that DIG_PER_DEC1 zeros?
Leading zero 'digits' are truncated, so we never get more than DIG_PER_DEC there. Actually we don't need to do that check at all (intg <= DIG_PER_DEC1), i removed it already.
Put it in an assert please. I find asserts quite useful as a documentation tool :) Then ok to push! Regards, Sergei Chief Architect MariaDB and security@mariadb.org
2139
Age (days ago)
2139
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sergei Golubchik