Hi Sergei, On Tue, Aug 02, 2016 at 07:22:14PM +0200, Sergei Golubchik wrote:

Hi, Sergey!

So, what did you do here? Did you change InnoDB's version of crc32 or just moved it to extra/ ? Just moved it to extra, no changes to crc32-vpmsum code. Also let server use it on PPC64LE.

You removed mysys/my_crc32.c - where will crc32 come from on x86?

That was a deadcode.

Why did you name new function crc32_vpmsum instead of just naming it crc32 and avoding #ifdef's elsewhere?

Well, I didn't name it. The name was chosen by library authors. I can see only one ifdef that can be avoided (mysys/checksum.c). InnoDB never calls crc32(), so it has to have this mess. I can change it, but my preference is to keep it and make my_checksum() static inline instead.

On Jul 05, Sergey Vojtovich wrote:

...

revision-id: e252dae86392a2b50d647a380db36fb8b01bf405 (mariadb-10.2.1-5-ge252dae) parent(s): 72c94872835f27b536f617978dbc664ddb57da06 committer: Sergey Vojtovich timestamp: 2016-07-05 18:09:23 +0400 message:

MDEV-9872 - Add common optimized CRC32 function interface

Move crc32-vpmsum to extra. Compile static crc32-vpmsum instead of adding sources directly. Make use of crc32-vpmsum via my_checksum().

Based on contribution by Daniel Black.

Thanks, Sergey