[Maria-developers] Warnings in MariaDB
Hi! Some more warnings (from another compiler) ------ In PBXT: cache_xt.cc:377: warning: converting to non-pointer type 'unsigned int' from NULL cache_xt.cc:1382: warning: converting to non-pointer type 'int' from NULL ../../storage/xtradb/include/buf0buf.ic:1059: warning: unused parameter 'mtr' ------------ In XtraDB: srv/srv0srv.c:1095: warning: value computed is not used srv/srv0srv.c:1125: warning: value computed is not used srv/srv0srv.c:1314: warning: value computed is not used Should I do bug reports for the above, or can you just fix this next time you push? Regards, Monty
Hi Monty, Thanks for the information. For PBXT I think it would be best if you correct such errors immediately when compiling and then push to the MariaDB tree, because without the exact compiler you are using, we cannot confirm that the warnings have indeed been removed. We will see to it that any changes made to PBXT in MariaDB find there way into the PBXT trunk. Of course you can also send a patch for the PBXT trunk, but this should not be necessary for such small changes, where it is obvious why they were done. Best regards, Paul On Oct 25, 2009, at 4:41 PM, Michael Widenius wrote:
Hi!
Some more warnings (from another compiler)
------
In PBXT:
cache_xt.cc:377: warning: converting to non-pointer type 'unsigned int' from NULL cache_xt.cc:1382: warning: converting to non-pointer type 'int' from NULL ../../storage/xtradb/include/buf0buf.ic:1059: warning: unused parameter 'mtr'
------------
In XtraDB:
srv/srv0srv.c:1095: warning: value computed is not used srv/srv0srv.c:1125: warning: value computed is not used srv/srv0srv.c:1314: warning: value computed is not used
Should I do bug reports for the above, or can you just fix this next time you push?
Regards, Monty
-- Paul McCullagh PrimeBase Technologies www.primebase.org www.blobstreaming.org pbxt.blogspot.com
Hi!
"Paul" == Paul McCullagh <paul.mccullagh@primebase.org> writes:
Paul> Hi Monty, Paul> Thanks for the information. Paul> For PBXT I think it would be best if you correct such errors Paul> immediately when compiling and then push to the MariaDB tree, because Paul> without the exact compiler you are using, we cannot confirm that the Paul> warnings have indeed been removed. Ok, I will do that. (now done, will be in next push) I hope you are fine with me fixing all compiler warnings we find... Paul> We will see to it that any changes made to PBXT in MariaDB find there Paul> way into the PBXT trunk. Of course you can also send a patch for the Paul> PBXT trunk, but this should not be necessary for such small changes, Paul> where it is obvious why they were done. Thanks! Regards, Monty
Hi Monty, On Oct 30, 2009, at 3:09 PM, Michael Widenius wrote:
Hi!
"Paul" == Paul McCullagh <paul.mccullagh@primebase.org> writes:
Paul> Hi Monty, Paul> Thanks for the information.
Paul> For PBXT I think it would be best if you correct such errors Paul> immediately when compiling and then push to the MariaDB tree, because Paul> without the exact compiler you are using, we cannot confirm that the Paul> warnings have indeed been removed.
Ok, I will do that. (now done, will be in next push)
OK thanks. I have also already made the changes to PBXT.
I hope you are fine with me fixing all compiler warnings we find...
Absolutely! I will fix any warning that comes up, because it makes for better software. And, this is also a requirement for compiling with Drizzle, which uses -Werror
Paul> We will see to it that any changes made to PBXT in MariaDB find there Paul> way into the PBXT trunk. Of course you can also send a patch for the Paul> PBXT trunk, but this should not be necessary for such small changes, Paul> where it is obvious why they were done.
Thanks!
Regards, Monty
-- Paul McCullagh PrimeBase Technologies www.primebase.org www.blobstreaming.org pbxt.blogspot.com
participants (2)
-
Michael Widenius -
Paul McCullagh