Hi Alexey, Thanks for your review! On 04/22/2017 06:49 PM, Alexey Botchkov wrote:

Ok to push. I'd only move the bool Item_func_min_max::fix_attributes(Item **items, uint nitems) function to the item_func.h as it's just the typehandler method call now.

I'm afraid this is not possible. This method uses current_thd->is_error(), and the structure of THD is not visible in item_func.h.

Best regards. HF

On Sat, Apr 15, 2017 at 7:23 AM, Alexander Barkov <bar@mariadb.org <mailto:bar@mariadb.org>> wrote:

Hello Alexey,

Can you please review a patch for MDEV-12506?

Thanks.