[Maria-developers] Review/help needed with MDEV-532
Hi Serg! I've pushed the MDEV-181/MDEV-225/MDEV-232 to 10.0-base, thanks for review! As you remember, we discussed extending it with a separate patch for doing the checkpoint inside InnoDB in an asynchroneous manner. I have created MDEV-532 for this. It was not hard to create the patch, and it seems to work. But I could use some help with one last test failure that I am somewhat mystified by: rpl.rpl_binlog_index 'row' w7 [ fail ] Found warnings/errors in server log file! Test ended at 2012-09-13 15:44:01 line 120913 15:43:48 [ERROR] mysqld: Table './test/t1' is marked as crashed and should be repaired 120913 15:43:48 [Warning] Checking table: './test/t1' 120913 15:43:48 [ERROR] test.t1: 1 client is using or hasn't closed the table properly I assume this is related to how I create a background thread for the binlog, something that I do wrong or fail to do, so any suggestions on where to look would be appreciated. I have pushed the code here: lp:~maria-captains/maria/10.0-knielsen - Kristian.
Hi Serg! Kristian Nielsen <knielsen@knielsen-hq.org> writes:
rpl.rpl_binlog_index 'row' w7 [ fail ] Found warnings/errors in server log file! Test ended at 2012-09-13 15:44:01 line 120913 15:43:48 [ERROR] mysqld: Table './test/t1' is marked as crashed and should be repaired 120913 15:43:48 [Warning] Checking table: './test/t1' 120913 15:43:48 [ERROR] test.t1: 1 client is using or hasn't closed the table properly
I assume this is related to how I create a background thread for the binlog,
I think I figured this out. I was confused by how the replication code uses the same MYSQL_BIN_LOG class for the binlog and the relay log. There is a flag MYSQL_BIN_LOG::is_relay_log that can be used to distinguish, but it was set much too late in the code. Once I changed this, my problem seems to have disappeared. I'll still need review; I'll commit a new patch shortly and point you to it, but it is not urgent. - Kristian.
participants (1)
-
Kristian Nielsen