On 02/19/2013 09:22 PM, Christian Convey wrote:

Hi Igor,

So is the basic rule: if MariaDB developers have modified a file in bzr since summer 2009, then I can assume that file belongs to MariaDB and won't be automatically over-written by the next MySQL release?

We touched a lot of functions, but only a few of them were added by MariaDB. Regards, Igor.

- Christian

On Tue, Feb 19, 2013 at 10:46 PM, Igor Babaev wrote:

...

On 02/19/2013 04:59 PM, Christian Convey wrote:

...

Hi guys,

As I work through the Coverity Scan results of MariaDB's trunk, I find myself having to research what some functions do, and the meanings of their parameters and return values. Rather than just recording what I learn on a piece of paper, I thought it might be nice to write Doxygen comments for some of those functions / structs / etc. That way, perhaps other persons trying to learn the code base could benefit.

Here's the problem. Based on Monty's blog posting about MariaDB 10 vs. MySQL 5.6 ( http://blog.mariadb.org/mariadb-10-0-and-mysql-5-6/ ), it's not obvious to me which files / functions / etc. in MariaDB have been forked from MariaDB, vs. which ones will be replaced with the corresponding MySQL code when the next MySQL release comes out. This means that when I write Doxygen comments for a given file / function /struct / etc., I don't know whether to submit that comment patch to the MariaDB project or to the MySQL project.

Does anyone know I I can figure that out?

See in bzr who committed the patch and when the patch was committed. MariaDB developers started committing their patches mainly in summer/fall 2009 (there are some earlier patches from Kristian, Monty, Sanja and, maybe, from Sergey Petrunia)

...

Thanks, Christian

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Hi Sergei, Thanks, I'll do that. - Christian On Wed, Feb 20, 2013 at 2:50 AM, Sergei Golubchik wrote:

Hi, Christian!

On Feb 19, Christian Convey wrote:

...

Hi guys,

As I work through the Coverity Scan results of MariaDB's trunk, I find myself having to research what some functions do, and the meanings of their parameters and return values. Rather than just recording what I learn on a piece of paper, I thought it might be nice to write Doxygen comments for some of those functions / structs / etc. That way, perhaps other persons trying to learn the code base could benefit.

Here's the problem. Based on Monty's blog posting about MariaDB 10 vs. MySQL 5.6 ( http://blog.mariadb.org/mariadb-10-0-and-mysql-5-6/ ), it's not obvious to me which files / functions / etc. in MariaDB have been forked from MariaDB, vs. which ones will be replaced with the corresponding MySQL code when the next MySQL release comes out. This means that when I write Doxygen comments for a given file / function /struct / etc., I don't know whether to submit that comment patch to the MariaDB project or to the MySQL project.

Does anyone know I I can figure that out?

Are you looking at 10.0? Feel free to send everything to us.

Regards, Sergei