[Maria-developers] Working on spider patches, MDEV-7698

newer
Re: [Maria-developers] Review for...

older
Re: [Maria-developers] 1579140:...

Michael Widenius

21 Nov 2016 21 Nov '16

9:30 a.m.

Hi! I have now started to work on the spider patches for MariaDB 10.2, MDEV-7698. I have moved all code from maria-10.1-spider to a new branch maria-10.2-spider and added some more patches. I have closed all related MDEV's in MDEV-7698 that is now included in 10.2-spider. While doing this, I noticed that spider/handler test was not included in the test suite. I added the missing suite.pm and suite.opt files and got the tests to work. However, when I tried to run test to verify my changes, I noticed that a lot of test in spider/handler where failing: mysql-test-run --suite=spider/handler produces these failures: spider/handler.spider3_fixes spider/handler.direct_aggregate spider/handler.direct_update spider/handler.spider_fixes spider/handler.function spider/handler.ha spider/handler.vp_fixes All failures are because .test and .result file doesn't match. I checked the patch file: http://spiderformysql.com/downloads/spider-3.2/patch_mariadb-10.1.8.tgz but this doesn't include any updates to the handler test files: grep mysql_test * returns nothing. However the .tar file: http://spiderformysql.com/downloads/spider-3.2/mariadb-10.1.8-spider-3.2-vp-... Contains a lot of updated .test and .result files. Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ? Another question: After applying the patches: 013_mariadb-10.0.15.vp_handler.diff 034_mariadb-10.0.15.vp_handler2.diff 005_mariadb-10.0.15.hs.diff 041_mariadb-10.0.15.vp_handler2.diff I get the following change in spider/handler/basic_sql.result: --- a/storage/spider/mysql-test/spider/handler/r/basic_sql.result +++ b/storage/spider/mysql-test/spider/handler/r/basic_sql.result @@ -70,6 +70,12 @@ CREATE TABLE ta_l ( PRIMARY KEY(a) ) MASTER_1_ENGINE MASTER_1_CHARSET MASTER_1_COMMENT_2_1 IGNORE SELECT a, b, c FROM tb_l +Warnings: +Warning 1062 Duplicate entry '1' for key 'PRIMARY' +Warning 1062 Duplicate entry '2' for key 'PRIMARY' +Warning 1062 Duplicate entry '3' for key 'PRIMARY' +Warning 1062 Duplicate entry '4' for key 'PRIMARY' +Warning 1062 Duplicate entry '5' for key 'PRIMARY' I can't figure out,why we get the above warnings. This is from a patch we discussed at booking.com one year ago. Any explanation for the above warnings would be appreciated. You can branch 10.2-spider and check the current state. Regards, Monty

Show replies by date

kentoku

23 Nov 23 Nov

2:38 p.m.

Hi Monty! Thank you for starting this task. I appreciate it.

...

Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it.

...

I can't figure out,why we get the above warnings. This is from a patch we discussed at booking.com one year ago. Any explanation for the above warnings would be appreciated.

You can branch 10.2-spider and check the current state.

O.K. I'll check it. Thanks, Kentoku 2016-11-21 17:30 GMT+09:00 Michael Widenius :

...

Hi!

I have now started to work on the spider patches for MariaDB 10.2, MDEV-7698.

I have moved all code from maria-10.1-spider to a new branch maria-10.2-spider and added some more patches. I have closed all related MDEV's in MDEV-7698 that is now included in 10.2-spider.

While doing this, I noticed that spider/handler test was not included in the test suite. I added the missing suite.pm and suite.opt files and got the tests to work.

However, when I tried to run test to verify my changes, I noticed that a lot of test in spider/handler where failing:

mysql-test-run --suite=spider/handler produces these failures:

spider/handler.spider3_fixes spider/handler.direct_aggregate spider/handler.direct_update spider/handler.spider_fixes spider/handler.function spider/handler.ha spider/handler.vp_fixes

All failures are because .test and .result file doesn't match.

I checked the patch file: http://spiderformysql.com/downloads/spider-3.2/patch_mariadb-10.1.8.tgz but this doesn't include any updates to the handler test files: grep mysql_test * returns nothing.

However the .tar file: http://spiderformysql.com/downloads/spider-3.2/mariadb-10.1.8-spider-3.2-vp-... Contains a lot of updated .test and .result files.

Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

Another question: After applying the patches:

013_mariadb-10.0.15.vp_handler.diff 034_mariadb-10.0.15.vp_handler2.diff 005_mariadb-10.0.15.hs.diff 041_mariadb-10.0.15.vp_handler2.diff

I get the following change in spider/handler/basic_sql.result:

--- a/storage/spider/mysql-test/spider/handler/r/basic_sql.result +++ b/storage/spider/mysql-test/spider/handler/r/basic_sql.result @@ -70,6 +70,12 @@ CREATE TABLE ta_l ( PRIMARY KEY(a) ) MASTER_1_ENGINE MASTER_1_CHARSET MASTER_1_COMMENT_2_1 IGNORE SELECT a, b, c FROM tb_l +Warnings: +Warning 1062 Duplicate entry '1' for key 'PRIMARY' +Warning 1062 Duplicate entry '2' for key 'PRIMARY' +Warning 1062 Duplicate entry '3' for key 'PRIMARY' +Warning 1062 Duplicate entry '4' for key 'PRIMARY' +Warning 1062 Duplicate entry '5' for key 'PRIMARY'

I can't figure out,why we get the above warnings. This is from a patch we discussed at booking.com one year ago. Any explanation for the above warnings would be appreciated.

You can branch 10.2-spider and check the current state.

Regards, Monty

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Michael Widenius

24 Nov 24 Nov

4:18 p.m.

Hi! On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote:

...

Hi Monty!

Thank you for starting this task. I appreciate it.

...
Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it.

I will start working on applying the test files to 10.2-spider now I was mostly confused by that in the current 10.2 the test and result files doesn't match.

...

...
I can't figure out,why we get the above warnings. This is from a patch we discussed at booking.com one year ago. Any explanation for the above warnings would be appreciated.

You can branch 10.2-spider and check the current state.

O.K. I'll check it.

Please send an email when you have figured out why we get the new warnings. This looks very strange. Here is the executed code with warnings: mysql-test-run spider/handler.basic_sql CREATE TABLE ta_l ( PRIMARY KEY(a) ) ENGINE=Spider DEFAULT CHARSET=utf8 COMMENT='database "auto_test_remote", table "ta_r"' CONNECTION='host "localhost", socket "/home/my/maria-10.2-spider/mysql-test/var/tmp/mysqld.2.1.sock", user "root", password ""' IGNORE SELECT a, b, c FROM tb_l; Warnings: Warning 1062 Duplicate entry '1' for key 'PRIMARY' Warning 1062 Duplicate entry '2' for key 'PRIMARY' Warning 1062 Duplicate entry '3' for key 'PRIMARY' Warning 1062 Duplicate entry '4' for key 'PRIMARY' Warning 1062 Duplicate entry '5' for key 'PRIMARY But when we do a select from the table, it looks like all rows are there. Is this because the table ta_l is connected to a remote table trough spider that already has the rows in it ? If yes, then it would be good to have a comment about this is in the test and also insert data that is different from the original one to make this part clear. Regards, Monty

Michael Widenius

4:55 p.m.

Hi! On Thu, Nov 24, 2016 at 5:18 PM, Michael Widenius wrote:

...

Hi!

On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote:

...
Hi Monty!

Thank you for starting this task. I appreciate it.

...
Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it.

All spider tests now passes in 10.2 I removed a few changes in test results that was affected by some of the not yet pushed patches, like: SHOW STATUS LIKE 'Spider_direct_aggregate'; Variable_name Value ! Spider_direct_aggregate 1 This fails as the above variable doesn't yet exists. I will update the test results as soon the variable exists again. Thanks! Regards, Monty

kentoku

30 Nov 30 Nov

2:03 p.m.

Hi!

...

All spider tests now passes in 10.2

Great!

...

This fails as the above variable doesn't yet exists. I will update the test results as soon the variable exists again.

ok. Thanks, Kentoku 2016-11-25 0:55 GMT+09:00 Michael Widenius :

...

Hi!

On Thu, Nov 24, 2016 at 5:18 PM, Michael Widenius wrote:

...
Hi!

On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote:

...
Hi Monty!

Thank you for starting this task. I appreciate it.

...
Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it.

All spider tests now passes in 10.2

I removed a few changes in test results that was affected by some of the not yet pushed patches, like:

SHOW STATUS LIKE 'Spider_direct_aggregate'; Variable_name Value ! Spider_direct_aggregate 1

This fails as the above variable doesn't yet exists. I will update the test results as soon the variable exists again.

Thanks!

Regards, Monty

kentoku

2:03 p.m.

Hi!

...

Is this because the table ta_l is connected to a remote table trough spider that already has the rows in it ?

Yes.

...

If yes, then it would be good to have a comment about this is in the test and also insert data that is different from the original one to make this part clear.

This test is create table with insert ignore test. So I am expecting warnings. Previous test is create table with insert test, so I don't think the insert data should be changed. But is it looks unclear? Should I add any comments? Thanks, Kentoku 2016-11-25 0:18 GMT+09:00 Michael Widenius :

...

Hi!

On Wed, Nov 23, 2016 at 3:38 PM, kentoku wrote:

...
Hi Monty!

Thank you for starting this task. I appreciate it.

...
Kentoku, do you have patches for the test files, or should I just take them from the above spider branch or from somewhere else ?

I just attached test files into MDEV-7698. Please use it. And please let me know if you get a error from test. Sometimes, test results are changed by patches. In this case I should check it.

I will start working on applying the test files to 10.2-spider now I was mostly confused by that in the current 10.2 the test and result files doesn't match.

...
...
I can't figure out,why we get the above warnings. This is from a patch we discussed at booking.com one year ago. Any explanation for the above warnings would be appreciated.

You can branch 10.2-spider and check the current state.

O.K. I'll check it.

Please send an email when you have figured out why we get the new warnings. This looks very strange.

Here is the executed code with warnings: mysql-test-run spider/handler.basic_sql

CREATE TABLE ta_l ( PRIMARY KEY(a) ) ENGINE=Spider DEFAULT CHARSET=utf8 COMMENT='database "auto_test_remote", table "ta_r"' CONNECTION='host "localhost", socket "/home/my/maria-10.2-spider/mysql-test/var/tmp/mysqld.2.1.sock", user "root", password ""' IGNORE SELECT a, b, c FROM tb_l; Warnings: Warning 1062 Duplicate entry '1' for key 'PRIMARY' Warning 1062 Duplicate entry '2' for key 'PRIMARY' Warning 1062 Duplicate entry '3' for key 'PRIMARY' Warning 1062 Duplicate entry '4' for key 'PRIMARY' Warning 1062 Duplicate entry '5' for key 'PRIMARY

But when we do a select from the table, it looks like all rows are there.

Is this because the table ta_l is connected to a remote table trough spider that already has the rows in it ? If yes, then it would be good to have a comment about this is in the test and also insert data that is different from the original one to make this part clear.

Regards, Monty

2839

Age (days ago)

2848

Last active (days ago)

List overview

Download

5 comments

2 participants

participants (2)

kentoku
Michael Widenius