Re: [Maria-developers] [Commits] Rev 3768: MDEV-5717: Server crash with insert statement containing DEFAULT into view
Hi, Sanja! On Mar 12, sanja@montyprogram.com wrote:
revno: 3768 revision-id: sanja@montyprogram.com-20140312103416-3v6tan06crsqry28 parent: sanja@montyprogram.com-20140307115707-poaet8iwv9d55azm committer: sanja@montyprogram.com branch nick: work-maria-5.3-MDEV-5717 timestamp: Wed 2014-03-12 12:34:16 +0200 message: MDEV-5717: Server crash with insert statement containing DEFAULT into view
Item_default_value::arg can be NULL so walk() should take it into consideration.
=== modified file 'sql/item.h' --- a/sql/item.h 2014-02-19 13:45:33 +0000 +++ b/sql/item.h 2014-03-12 10:34:16 +0000 @@ -3551,7 +3551,7 @@ public:
bool walk(Item_processor processor, bool walk_subquery, uchar *args) { - return arg->walk(processor, walk_subquery, args) || + return (arg && arg->walk(processor, walk_subquery, args)) || (this->*processor)(args); }
Ok to push. But *please* install the diff_p bzr plugin as described here: https://mariadb.com/kb/en/how-to-get-more-out-of-bzr-when-working-on-mariadb... Regards, Sergei
participants (1)
-
Sergei Golubchik