Re: [Maria-developers] review of the MDEV-377 Name support for dynamic columns

21 Dec
2012
21 Dec
'12
9:17 a.m.
Hi, Oleksandr! On Dec 21, Oleksandr Byelkin wrote:
It looks like you reviewed some old sources in 10.0-cassandra this is fixed as we discussed it.
I've reviewed the 5.5-cassandra tree. And yes, I thought that was already fixed, so I was a bit susprised to find it unfixed :) Ok, wrong tree, then. Thanks!
The difference is - you pass a separate pointer to the caller, that a caller should take care of. If you put this memory in dynarray, than the caller doesn't have to bother. He eventually delete_dynamic() and that does all the necessary cleanup. It's easier to use for the caller - and for API it's extremely important. More important than simple implementation. Regards, Sergei
4491
Age (days ago)
4491
Last active (days ago)
0 comments
1 participants
participants (1)
-
Sergei Golubchik