-----Original Message----- From: Haidong Ji [mailto:haidong.ji@gmail.com] Sent: Montag, 31. Januar 2011 16:02 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

Wlad,

I will be able to do some testing with this, perhaps in the next 10 days or so. I can test the upgrade on 32-bit, 64-bit, and a variety version of Windows (2003, 2008, 2008 R2), if necessary.

Haidong Ji

On Mon, Jan 31, 2011 at 8:28 AM, Vladislav Vaintroub wrote:

...

Hi all, I updated the MWL#55 (Windows installer) with the upgrade information. Now, people will be able to upgrade between prior MariaDB (or prior MySQL) versions using upgrade wizard, which is by default launched at the end of installation, if upgradable instances are found .  Users will also be able to use Upgrade Wizard  after the installation, at any the time convenient for them. Upgrade wizard will also be included into ZIP distribution. Besides GUI Wizard, there is a command line utility mysql_upgrade_service.exe  to

...

all operations  necessary to  upgrade an existing database instance registered as service (in fact GUI wizard uses this mysql_upgrade_service.exe as "backend").

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to

...

WL last time I used it was more than  a decade ago), it is also restricted to MFC only. Being MFC application, it will require  at least VS Professional to build.  There is no MFC in  free Visual Studio Express edition,  nor in free Windows SDK.  Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard,  package won't include it , and installer won't  start it at the end of installation).

The repository that includes the final windows installer is  lp:~maria-captains/maria/5.2-windows-packaging-upgrade

Building installer is described in http://askmonty.org/worklog/Server-Sprint/?tid=55 (Section "Building installer", at the very start of the WL).

Monty or Sergei (or volunteers if any): Can you please have a look the above repo and do a review . I tried to split the big

Hello again, I put 32 and 64 bit installers I built here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share Have fun, Wlad perform this patch

...

into parts,  but I did not find the result to be too satisfactory

Philip: would you be able to test the upgrade wizard?  You need a service running under some older mysqld.exe binary (e.g. install MySQL 5.1), you'll should get upgrade wizard launched at the end of install. You should also get Wizard at the end of installation any time you have an older version of Maria running as service.

Thanks and best regards,

Wlad

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to     : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help   : https://help.launchpad.net/ListHelp

-----Original Message----- From: Haidong Ji [mailto:haidong.ji@gmail.com] Sent: Montag, 31. Januar 2011 16:02 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

Wlad,

I will be able to do some testing with this, perhaps in the next 10 days or so. I can test the upgrade on 32-bit, 64-bit, and a variety version of Windows (2003, 2008, 2008 R2), if necessary.

Haidong Ji

On Mon, Jan 31, 2011 at 8:28 AM, Vladislav Vaintroub wrote:

...

Hi all, I updated the MWL#55 (Windows installer) with the upgrade information. Now, people will be able to upgrade between prior MariaDB (or prior MySQL) versions using upgrade wizard, which is by default launched at the end of installation, if upgradable instances are found . Users will also be able to use Upgrade Wizard after the installation, at any the time convenient for them. Upgrade wizard will also be included into ZIP distribution. Besides GUI Wizard, there is a command line utility mysql_upgrade_service.exe to

...

all operations necessary to upgrade an existing database instance registered as service (in fact GUI wizard uses this mysql_upgrade_service.exe as "backend").

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to

...

WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

The repository that includes the final windows installer is lp:~maria-captains/maria/5.2-windows-packaging-upgrade

Building installer is described in http://askmonty.org/worklog/Server-Sprint/?tid=55 (Section "Building installer", at the very start of the WL).

Monty or Sergei (or volunteers if any): Can you please have a look the above repo and do a review . I tried to split the big

From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Montag, 31. Januar 2011 18:45 To: Vladislav Vaintroub Cc: Haidong Ji; maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished. @Vladislav .. 1) surprised it is only 22 MB. This is not a full build I think (with all clients, tests etc - and I think you cannot redistribute docs for license reasons), but rather something similar to 'mysql_essentials' package from MySQL/Oracle? Can you clarify what is omitted as compared to .zip package? In a “full” MariaDB package there would be debug symbols, debug binaries and embedded. There won’t be tests (there is a huge number of them, and they will expand the package size in ~120MB range, and additionally slow down installation quite a bit). 50MB per file is the limit on Live, so I dropped the least useful stuff for this demo (e.g build without embedded, and skipped debug build. And removed DebugInfo from my local copy of win/packaging/CPackWixConfig.cmake) 2) I did not find an option to specify the installation path. Am I right? On the feature selection screen (I think the title of the dialog is “Customize MariaDB5.2 installation”), there is a “Browse” button, that allows you to install the package to the place you want. You can select “Database Instance” feature and put it to yet another place. This “Browse” button is not available during “Maintenance”, only on initial installation. -- Peter On Mon, Jan 31, 2011 at 18:20, Vladislav Vaintroub < mailto:wlad@montyprogram.com wlad@montyprogram.com> wrote: Hello again, I put 32 and 64 bit installers I built here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share Have fun, Wlad perform this patch

...

into parts, but I did not find the result to be too satisfactory

Philip: would you be able to test the upgrade wizard? You need a service running under some older mysqld.exe binary (e.g. install MySQL 5.1), you'll should get upgrade wizard launched at the end of install. You should also get Wizard at the end of installation any time you have an older version of Maria running as service.

Thanks and best regards,

Wlad

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

hmmm .. installer rolls back. Why? 64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left. -- Peter On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote:

...

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to this WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

...

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified.

I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG).

...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

...

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Same problem with 64 bit. Installation path, port and service name does not matter. i am not upgrading (path, port, service are all new). Rollback occurs after 'running install_mysql_db.exe' (or similar) occurs in the installer splash screen. -- Peter On Tue, Feb 1, 2011 at 18:45, Peter Laursen wrote:

sorry .. it was 32 bit installer!

On Tue, Feb 1, 2011 at 18:43, Peter Laursen wrote:

...

hmmm .. installer rolls back. Why?

64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left.

-- Peter

On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote:

...

...

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to this WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

...

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified.

I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG).

...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

...

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to

This could be a bug I found and fixed yesterday evening. It turns out I did an superfluous LocalFree() in mysql_install_db.exe. Interestingly, it has crashed rather seldom, it was the first time I have seen it. Fixed here : http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr... . I updated msi installers after the fix here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share . I would appreciate if you could give new MSI’s a try . Make sure to uninstall what you currently have prior to this experiment . To trace what is happening in installation, a log file can be helpful. To get a log, issue msiexec /i mariadb-5.2.5-win32.msi /l*v log.txt on the command line. This will launch setup and write some interesting (and lots of uninteresting) info into log.txt. If an executable launched by MSI crashes (I presumably it was the case here), the information would be sparse, but at least one would know at what step installation did a rollback, which exe has crashed and what it has written to output prior to crash. Wlad From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Dienstag, 1. Februar 2011 18:46 To: Vladislav Vaintroub Cc: Kristian Nielsen; serg@askmonty.org; maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished. sorry .. it was 32 bit installer! On Tue, Feb 1, 2011 at 18:43, Peter Laursen wrote: hmmm .. installer rolls back. Why? 64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left. -- Peter On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote: this

...

WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified. I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG). that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to

Thanks Peter. This might be helpful. Is this a localized Windows? Asking because error you get is ERROR_INVALID_SERVICE_ACCOUNT, and the service account is NT Authority\Network Service, which is “well-known” and always there. However I recall there was some PITA with localized names for standard users mentioned in source code in other open source projects (e.g. Wix). I was never affected since I do not run localized Windows, though now I think I should give them a try from time to time;) From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Dienstag, 1. Februar 2011 19:52 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished. I am sorry .. no luck either this time. I executed: "C:\m>msiexec /i mariadb-5.2.5-winx64.msi /l*v log.txt" It looks like it is the service creation that fails .. excerpt CAQuietExec: Running bootstrap CAQuietExec: Removing default user CAQuietExec: Changing root password CAQuietExec: Creating my.ini file CAQuietExec: Registering service CAQuietExec: FATAL ERROR: CreateService failed (1057) CAQuietExec: Error 0x80070001: Command line returned an error. CAQuietExec: Error 0x80070001: CAQuietExec Failed CustomAction CreateDatabase returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox) (full installation log attached). I specified service name 'maria52' and no such service exist. Port specified is 3310 what is not in use. Selected default path for installation. I am administrator user of course and UAC is disabled. -- Peter On Tue, Feb 1, 2011 at 19:20, Vladislav Vaintroub wrote: This could be a bug I found and fixed yesterday evening. It turns out I did an superfluous LocalFree() in mysql_install_db.exe. Interestingly, it has crashed rather seldom, it was the first time I have seen it. Fixed here : http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr... . I updated msi installers after the fix here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share . I would appreciate if you could give new MSI’s a try . Make sure to uninstall what you currently have prior to this experiment . To trace what is happening in installation, a log file can be helpful. To get a log, issue msiexec /i mariadb-5.2.5-win32.msi /l*v log.txt on the command line. This will launch setup and write some interesting (and lots of uninteresting) info into log.txt. If an executable launched by MSI crashes (I presumably it was the case here), the information would be sparse, but at least one would know at what step installation did a rollback, which exe has crashed and what it has written to output prior to crash. Wlad From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Dienstag, 1. Februar 2011 18:46 To: Vladislav Vaintroub Cc: Kristian Nielsen; serg@askmonty.org; maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished. sorry .. it was 32 bit installer! On Tue, Feb 1, 2011 at 18:43, Peter Laursen wrote: hmmm .. installer rolls back. Why? 64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left. -- Peter On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote: this

...

WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified. I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG). that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

But I do not think "NT Authority\Network Service is localized" (it only is in Czech and other tonguebreaking languages and also not from Vista onwards as far as I remember. In Vista/2008/7 localization only applies to GUI and not command syntax) Also isn't 'NT AUTHORITY\SYSTEM' what user account MySQL normally uses? But using \Network Service may be an improvement .. I remember we had some discussions. :-) If you need more information from my system just ask for a registry key dump or the output from some specific command. -- Peter On Tue, Feb 1, 2011 at 20:30, Peter Laursen wrote:

It is a Danish Windows (Home Premium 64 bit).

On Tue, Feb 1, 2011 at 20:07, Vladislav Vaintroub wrote:

...

Thanks Peter.

This might be helpful. Is this a localized Windows? Asking because error you get is ERROR_INVALID_SERVICE_ACCOUNT, and the service account is NT Authority\Network Service, which is “well-known” and always there. However I recall there was some PITA with localized names for standard users mentioned in source code in other open source projects (e.g. Wix). I was never affected since I do not run localized Windows, though now I think I should give them a try from time to time;)

*From:* Peter Laursen [mailto:peter_laursen@webyog.com] *Sent:* Dienstag, 1. Februar 2011 19:52

*To:* Vladislav Vaintroub *Cc:* maria-developers@lists.launchpad.net *Subject:* Re: [Maria-developers] Windows installer MWL#55 finished.

I am sorry .. no luck either this time. I executed: "C:\m>msiexec /i mariadb-5.2.5-winx64.msi /l*v log.txt"

It looks like it is the service creation that fails .. excerpt

CAQuietExec: Running bootstrap CAQuietExec: Removing default user CAQuietExec: Changing root password CAQuietExec: Creating my.ini file CAQuietExec: Registering service CAQuietExec: FATAL ERROR: CreateService failed (1057) CAQuietExec: Error 0x80070001: Command line returned an error. CAQuietExec: Error 0x80070001: CAQuietExec Failed CustomAction CreateDatabase returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)

(full installation log attached).

I specified service name 'maria52' and no such service exist. Port specified is 3310 what is not in use. Selected default path for installation. I am administrator user of course and UAC is disabled.

-- Peter

On Tue, Feb 1, 2011 at 19:20, Vladislav Vaintroub wrote:

This could be a bug I found and fixed yesterday evening. It turns out I did an superfluous LocalFree() in mysql_install_db.exe. Interestingly, it has crashed rather seldom, it was the first time I have seen it.

Fixed here : http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr....

I updated msi installers after the fix here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share . I would appreciate if you could give new MSI’s a try . Make sure to uninstall what you currently have prior to this experiment .

To trace what is happening in installation, a log file can be helpful. To get a log, issue

msiexec /i mariadb-5.2.5-win32.msi /l*v log.txt

on the command line. This will launch setup and write some interesting (and lots of uninteresting) info into log.txt. If an executable launched by MSI crashes (I presumably it was the case here), the information would be sparse, but at least one would know at what step installation did a rollback, which exe has crashed and what it has written to output prior to crash.

Wlad

*From:* Peter Laursen [mailto:peter_laursen@webyog.com] *Sent:* Dienstag, 1. Februar 2011 18:46 *To:* Vladislav Vaintroub *Cc:* Kristian Nielsen; serg@askmonty.org; maria-developers@lists.launchpad.net

*Subject:* Re: [Maria-developers] Windows installer MWL#55 finished.

sorry .. it was 32 bit installer!

On Tue, Feb 1, 2011 at 18:43, Peter Laursen wrote:

hmmm .. installer rolls back. Why?

64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left.

-- Peter

On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote:

...

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to this WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

...

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified.

I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG).

...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

...

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

On Tue, Feb 1, 2011 at 23:00, Vladislav Vaintroub wrote:

*From:* Peter Laursen [mailto:peter_laursen@webyog.com] *Sent:* Dienstag, 1. Februar 2011 21:52

*To:* Vladislav Vaintroub *Cc:* maria-developers@lists.launchpad.net *Subject:* Re: [Maria-developers] Windows installer MWL#55 finished.

But I do not think "NT Authority\Network Service is localized" (it only is in Czech and other tonguebreaking languages and also not from Vista onwards as far as I remember. In Vista/2008/7 localization only applies to GUI and not command syntax)

Well, I see what the bug was.. IT must be written NetworkService without space, not „Network Service“ as I did it (at least MSDN documents it so). I’ll check again the whole installer on German VM, and come back when I have something new.,

Also isn't 'NT AUTHORITY\SYSTEM' what user account MySQL normally uses? But using \Network Service may be an improvement .. I remember we had some discussions. :-)

Yes, there were some discussion indeed in the bugdb.. http://bugs.mysql.com/bug.php?id=45216 (filed by you) for example .System account is the most powerful account, it is the same as “root” on Unix. That is, a bug in mysqld.exe (buffer overflow or something like that) potentially compromises the whole machine. How this could stay this way and pass all Sun and Oracle security reviews, is something I completely fail to understand.

NetworkService has by far less privileges, it does not need password and it can talk Kerberos (good property, as I think at some point Windows authentication will be in Maria as well). SQLServer is using NetworkService to run, so it can’t be wrong.

Then I have a good question! If I install MariaDB with "mysqld -install' command from the .zip distribution under what user account will the service run (SYSTEM or NETWORK) ? I guess that in this respect MariaDB code is not different from MySQL? :-) And also there seems to be no 64 bit .zip?

If you need more information from my system just ask for a registry key dump or the output from some specific command.

Thanks for your offer, I think I will find that out, but will also come back if there are any questions.

-- Peter

On Tue, Feb 1, 2011 at 20:30, Peter Laursen wrote:

It is a Danish Windows (Home Premium 64 bit).

On Tue, Feb 1, 2011 at 20:07, Vladislav Vaintroub wrote:

Thanks Peter.

This might be helpful. Is this a localized Windows? Asking because error you get is ERROR_INVALID_SERVICE_ACCOUNT, and the service account is NT Authority\Network Service, which is “well-known” and always there. However I recall there was some PITA with localized names for standard users mentioned in source code in other open source projects (e.g. Wix). I was never affected since I do not run localized Windows, though now I think I should give them a try from time to time;)

*From:* Peter Laursen [mailto:peter_laursen@webyog.com] *Sent:* Dienstag, 1. Februar 2011 19:52

*To:* Vladislav Vaintroub *Cc:* maria-developers@lists.launchpad.net

*Subject:* Re: [Maria-developers] Windows installer MWL#55 finished.

I am sorry .. no luck either this time. I executed: "C:\m>msiexec /i mariadb-5.2.5-winx64.msi /l*v log.txt"

It looks like it is the service creation that fails .. excerpt

CAQuietExec: Running bootstrap CAQuietExec: Removing default user CAQuietExec: Changing root password CAQuietExec: Creating my.ini file CAQuietExec: Registering service CAQuietExec: FATAL ERROR: CreateService failed (1057) CAQuietExec: Error 0x80070001: Command line returned an error. CAQuietExec: Error 0x80070001: CAQuietExec Failed CustomAction CreateDatabase returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)

(full installation log attached).

I specified service name 'maria52' and no such service exist. Port specified is 3310 what is not in use. Selected default path for installation. I am administrator user of course and UAC is disabled.

-- Peter

On Tue, Feb 1, 2011 at 19:20, Vladislav Vaintroub wrote:

This could be a bug I found and fixed yesterday evening. It turns out I did an superfluous LocalFree() in mysql_install_db.exe. Interestingly, it has crashed rather seldom, it was the first time I have seen it.

Fixed here : http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr....

I updated msi installers after the fix here http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share . I would appreciate if you could give new MSI’s a try . Make sure to uninstall what you currently have prior to this experiment .

To trace what is happening in installation, a log file can be helpful. To get a log, issue

msiexec /i mariadb-5.2.5-win32.msi /l*v log.txt

on the command line. This will launch setup and write some interesting (and lots of uninteresting) info into log.txt. If an executable launched by MSI crashes (I presumably it was the case here), the information would be sparse, but at least one would know at what step installation did a rollback, which exe has crashed and what it has written to output prior to crash.

Wlad

*From:* Peter Laursen [mailto:peter_laursen@webyog.com] *Sent:* Dienstag, 1. Februar 2011 18:46 *To:* Vladislav Vaintroub *Cc:* Kristian Nielsen; serg@askmonty.org; maria-developers@lists.launchpad.net

*Subject:* Re: [Maria-developers] Windows installer MWL#55 finished.

sorry .. it was 32 bit installer!

On Tue, Feb 1, 2011 at 18:43, Peter Laursen wrote:

hmmm .. installer rolls back. Why?

64 bit build on 64 bit Win7 (UAC disabled). Default file path. No conflicts with ports or service name specified. After rollback there is no track left.

-- Peter

On Tue, Feb 1, 2011 at 18:05, Vladislav Vaintroub wrote:

...

-----Original Message----- From: Kristian Nielsen [mailto:knielsen@knielsen-hq.org] Sent: Dienstag, 1. Februar 2011 14:59 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Michael Widenius Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

"Vladislav Vaintroub" writes:

...

Wizard is an MFC application. I'm sorry for that, but my Windows C/C++ GUI programming experience is not only rusty (prior to this WL last time I used it was more than a decade ago), it is also restricted to MFC only. Being MFC application, it will require at least VS Professional to build. There is no MFC in free Visual Studio Express edition, nor in free Windows SDK. Build and packaging process will handle missing MFC gracefully (build won't try to compile upgrade wizard, package won't include it , and installer won't start it at the end of installation).

What license are we distributing the wizard source code under?

...

The reason I ask is that because of the above dependency, GPL may not be appropriate (and since it sounds like a new application, nor is it necessary). So we might consider another license, eg. BSD or if prefered some other more copy-left license. Or just GPL-with-MFC-exception.

I don't really have an opinion myself for one license or the other, I just wanted to point out the issue to make sure it is considered by those that do care. Since it sounds like if we just use GPL, we may be releasing something that formally others cannot redistribute without violating the license. Which I think we should avoid, even if we're obviously not planning to sue anyone over it ...

Not sure I'm correct person to start discussions over the of GPL, I think I'm not qualified.

I do know there is a plenty of established open source projects that use MFC, including GPLv2, such as different incarnations of Tortoise (SVN,CVS, BZR, HG).

...

From my point of view, it is just a system library. It came bundled with compiler, just like other library CRT which is non-GPL that we use extensively for quite important functionality like strcpy() or say fopen(). Maybe this explanation will satisfy GPL purists. I do not think CRT , MFC , ATL (libraries that come bundled with Visual Studio) have any written license, at least I have never seen one. The source code is available, and installed together with Visual Studio. If one needs to redistribute one of this libraries as DLLs, there is Microsoft EULA that basically allows inclusion into any software . But we do not even do that, as we link Visual Studio libraries (CRT, and also MFC now) statically, MySQL-ish way.

...

- Kristian.

_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

Hi Peter, all On 02/02/2011, at 8:24 AM, Peter Laursen wrote:

Also isn't 'NT AUTHORITY\SYSTEM' what user account MySQL normally uses? But using \Network Service may be an improvement .. I remember we had some discussions. :-)

Yes, there were some discussion indeed in the bugdb.. http://bugs.mysql.com/bug.php?id=45216 (filed by you) for example .System account is the most powerful account, it is the same as “root” on Unix. That is, a bug in mysqld.exe (buffer overflow or something like that) potentially compromises the whole machine. How this could stay this way and pass all Sun and Oracle security reviews, is something I completely fail to understand.

NetworkService has by far less privileges, it does not need password and it can talk Kerberos (good property, as I think at some point Windows authentication will be in Maria as well). SQLServer is using NetworkService to run, so it can’t be wrong.

Then I have a good question! If I install MariaDB with "mysqld - install' command from the .zip distribution under what user account will the service run (SYSTEM or NETWORK) ? I guess that in this respect MariaDB code is not different from MySQL? :-)

And also there seems to be no 64 bit .zip?

Could it have its own account? MSSQL probably ties in with lots of other things, mysqld is pretty self-contained and just needs network access and its local directory tree. Regards, Arjen. -- Arjen Lentz, Exec.Director @ Open Query (http://openquery.com) Remote expertise & maintenance for MySQL/MariaDB server environments. Follow us at http://openquery.com/blog/ & http://twitter.com/openquery

From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Dienstag, 1. Februar 2011 20:31 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

It is a Danish Windows (Home Premium 64 bit).

Hi Peter, As it turns out, installer had the same "localization" problem registering service on German Windows. Fixed now, I uploaded the msis to the same place http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share Thanks, Wlad

Fix confirmed. Now it installs on my system (as a fresh install. I did not try the upgrade wizard). And BTW: did I remember to congratulate the very nice rollback feature? Two more questions comments: 1) Your default install path is \program files [(x86)]. You copy the /datadir as a subfolder of /basedirr. This will cause problems on Vista+ with UAC enabled if the server is ever started from commandline as a non-service (also if the user doing so is an administrator user). Problem is that UAC will 'virtualize' every database file that is written to. Any change to database (DDL, DM, logs - whatever) will be lost next time the server starts as a service. I realize that most Windows users will never start the server from commandline. But still *in case \program files\.. is selected as /basedir*, /datadir should be in \program data I think (MS recommendation for UAC compliance with non-user programs). Refer: SHOW VARIABLES LIKE 'basedir'; -- C:\Program Files\MariaDB 5.2\ SHOW VARIABLES LIKE 'datadir'; -- C:\Program Files\MariaDB 5.2\data\ 2) There is no my.ini generated with a fresh install as far as I can see - so the server probably runs (it does!) with very low default buffer settings etc. Also latin1 charset and MyISAM will be default. I think a my.ini with settings fit for a 1GB-2GB RAM machine should be generated - and with a few configuration options. And a my.ini will be required to solve 1) anyway. But still it is a good installer (and there is a 64 bit one as well), so this is an important step in the right direction. So thanks for your effort! -- Peter On Wed, Feb 2, 2011 at 14:37, Peter Laursen wrote:

I am a little bit busy now, but will confirm tonight. -- Peter

On Wed, Feb 2, 2011 at 14:12, Vladislav Vaintroub wrote:

...

From: Peter Laursen [mailto:peter_laursen@webyog.com] Sent: Dienstag, 1. Februar 2011 20:31 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Windows installer MWL#55 finished.

...

It is a Danish Windows (Home Premium 64 bit).

Hi Peter, As it turns out, installer had the same "localization" problem registering service on German Windows. Fixed now, I uploaded the msis to the same place http://cid-ff0c950417b4f8a4.office.live.com/browse.aspx/share

Thanks, Wlad

-----Original Message----- From: Michael Widenius [mailto:monty@askmonty.org] Sent: Mittwoch, 2. Februar 2011 10:10 To: Vladislav Vaintroub Cc: maria-developers@lists.launchpad.net; serg@askmonty.org; Philip Stoev Subject: re: Windows installer MWL#55 finished.

Hi!

What parts do you want me to review ?

(When it comes to the installer myself, I am not of that much help as I don't know much about MFC applications).

Hi Monty, Perhaps command line utilities, mysql_install_db (exe) and mysql_upgrade_service.exe. They are listed under http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr... http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr... They are also listed as changesets 2921 and 2922 here http://bazaar.launchpad.net/~maria-captains/maria/5.2-windows-packaging-upgr... (they have slightly changed since they were first committed) Thanks, Wlad