[Maria-developers] MDEV-7802 adding status variables - backport to 10.0 request
Hi, I'm requesting a backport of MDEV-7802 https://github.com/MariaDB/server/pull/30/files to 10.0 It added status variables which where important to determining what operational values to set binlog_commit_wait_usec / binlog_commit_wait_count variables to. With parallel replication efficiency and general group commit IO reduction dependent on the tradeoff of these settings with the commit delay, the status variables binlog_group_commit_trigger_count, binlog_group_commit_trigger_timeout and binlog_group_commit_trigger_lock_wait that this patch adds are operationally important. The changes added a few variables and didn't affect the flow of the program at all. In the binary log execution path, no locks where added and only a few increments of static variables where added. There was an additional lock usage of LOCK_prepare_ordered in the show global status for the period to copy the added variables into the global status structures. I'm quite aware of the dangers of show global status holding locks wrongly (MDEV-7126) I don't suspect this does. On the balance of risk/benefit can I request that this feature be merged to 10.0. -- -- Daniel Black, Engineer @ Open Query (http://openquery.com.au) Remote expertise & maintenance for MySQL/MariaDB server environments.
Daniel Black <daniel.black@openquery.com> writes:
I'm requesting a backport of MDEV-7802 https://github.com/MariaDB/server/pull/30/files to 10.0
I don't mind putting the code in 10.0. However, normally we do not introduce new features (in this case: three new status variables) in stable versions. So I wanted to have someone else say they think this rule should be bent, before doing it ... - Kristian.
I have not checked the patch, and I am not a MariaDB Dev, but ... ...I think the rule should be bended here for the following reason: * This patch provides monitoring capabilities, * capabilities that are useful to trace performance regression and ease tuning, * and such features should get to user without delay. Jean-François Gagné On 2015-04-22 13:58, Kristian Nielsen wrote:
Daniel Black <daniel.black@openquery.com> writes:
I'm requesting a backport of MDEV-7802 https://github.com/MariaDB/server/pull/30/files to 10.0 I don't mind putting the code in 10.0.
However, normally we do not introduce new features (in this case: three new status variables) in stable versions. So I wanted to have someone else say they think this rule should be bent, before doing it ...
- Kristian.
Jean-François Gagné <jeanfrancois.gagne@booking.com> writes:
On 2015-04-22 13:58, Kristian Nielsen wrote:
Daniel Black <daniel.black@openquery.com> writes:
I'm requesting a backport of MDEV-7802 https://github.com/MariaDB/server/pull/30/files to 10.0 I don't mind putting the code in 10.0.
However, normally we do not introduce new features (in this case: three new status variables) in stable versions. So I wanted to have someone else say they think this rule should be bent, before doing it ...
So there were a couple of votes for backporting, and none against. So I will push this into 10.0 as well. - Kristian.
----- On 29 Apr, 2015, at 6:40 PM, Kristian Nielsen knielsen@knielsen-hq.org wrote:
So there were a couple of votes for backporting, and none against. So I will push this into 10.0 as well.
thank you very much. https://github.com/MariaDB/server/pull/30 ready to go. -- -- Daniel Black, Engineer @ Open Query (http://openquery.com.au) Remote expertise & maintenance for MySQL/MariaDB server environments.
participants (4)
-
Daniel Black -
Daniel Black -
Jean-François Gagné -
Kristian Nielsen