New subject: [Maria-developers] Rev 2752: Subquery optimization: Duplicate Elimination: process in file:///home/psergey/dev/maria-5.3-subqueries-r3/

8 Feb 2010

At file:///home/psergey/dev/maria-5.3-subqueries-r3/

------------------------------------------------------------
revno: 2752
revision-id: psergey@askmonty.org-20100208125530-l0o01n6lxk95cn78
parent: psergey@askmonty.org-20100208095616-ar502xdhoqqhe3nk
committer: Sergey Petrunya 
branch nick: maria-5.3-subqueries-r3
timestamp: Mon 2010-02-08 14:55:30 +0200
message:
  Subquery optimization: Duplicate Elimination: process
   temporary table overflow correctly.
=== modified file 'sql/sql_select.cc'

--- a/sql/sql_select.cc	2010-01-28 13:48:33 +0000
+++ b/sql/sql_select.cc	2010-02-08 12:55:30 +0000
@@ -16250,12 +16250,12 @@
   if (error)
   {
     /* create_internal_tmp_table_from_heap will generate error if needed */
-    if (sjtbl->tmp_table->file->is_fatal_error(error, HA_CHECK_DUP) &&
-        create_internal_tmp_table_from_heap(thd, sjtbl->tmp_table,
+    if (!sjtbl->tmp_table->file->is_fatal_error(error, HA_CHECK_DUP))
+      DBUG_RETURN(1); /* Duplicate */
+    if (create_internal_tmp_table_from_heap(thd, sjtbl->tmp_table,
                                             sjtbl->start_recinfo,
                                             &sjtbl->recinfo, error, 1))
       DBUG_RETURN(-1);
-    DBUG_RETURN(1);
   }
   DBUG_RETURN(0);
 }

    

[Maria-developers] Rev 2752: Subquery optimization: Duplicate Elimination: process in file:///home/psergey/dev/maria-5.3-subqueries-r3/

Sergey Petrunya

Michael Widenius

tags

participants (2)