[Maria-developers] MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler
Hello Nirbhay, Can you please review a patch for 10.3: MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler It also automatically fixed two problems: MDEV-11331 Wrong result for INSERT INTO t1 (datetime_field) VALUES (hybrid_function_of_TIME_data_type) MDEV-11333 Expect "Impossible where condition" for WHERE timestamp_field>=DATE_ADD(TIMESTAMP'9999-01-01 00:00:00',INTERVAL 1000 YEAR) because the new code is now symmetric for all data types. Thanks!
Hi Bar, On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov <bar@mariadb.org> wrote:
Hello Nirbhay,
Can you please review a patch for 10.3:
MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler
It also automatically fixed two problems:
MDEV-11331 Wrong result for INSERT INTO t1 (datetime_field) VALUES (hybrid_function_of_TIME_data_type) MDEV-11333 Expect "Impossible where condition" for WHERE timestamp_field>=DATE_ADD(TIMESTAMP'9999-01-01 00:00:00',INTERVAL 1000 YEAR)
because the new code is now symmetric for all data types.
Looks good. Ok to push. Best, Nirbhay
Thanks!
Hi Nirbhay. On 11/25/2016 02:31 AM, Nirbhay Choubey wrote:
Hi Bar,
On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov <bar@mariadb.org <mailto:bar@mariadb.org>> wrote:
Hello Nirbhay,
Can you please review a patch for 10.3:
MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler
It also automatically fixed two problems:
MDEV-11331 Wrong result for INSERT INTO t1 (datetime_field) VALUES (hybrid_function_of_TIME_data_type) MDEV-11333 Expect "Impossible where condition" for WHERE timestamp_field>=DATE_ADD(TIMESTAMP'9999-01-01 00:00:00',INTERVAL 1000 YEAR)
because the new code is now symmetric for all data types.
Looks good. Ok to push.
Thank you very much! Can you please go to the MDEV and do "Log Work" to record the time spent on reviewing? Thanks!
Best, Nirbhay
Thanks!
participants (2)
-
Alexander Barkov -
Nirbhay Choubey