Hi!

...

...

...

...

"Colin" == Colin Charles <colin@askmonty.org> writes:

Colin> Hi! Colin> I found this: Colin> http://tokutek.com/products/mysql-patches/ Colin> Its nice to know they mention MariaDB there. But more importantly, any Colin> thoughts on implementing these patches that MySQL has just dropped the Colin> ball on? Colin> http://bugs.mysql.com/bug.php?id=44927 - auto increment counter (serg Colin> has reviewed this before, fwiw) Colin> http://bugs.mysql.com/bug.php?id=45458 - support for multiple Colin> clustering indexes Colin> http://bugs.mysql.com/bug.php?id=45759 - notify an engine of full scan Colin> on secondary indexes (serg has also reviewed this before) This is already in MariaDB. Colin> Good job here. We implemented: Colin> http://bugs.mysql.com/bug.php?id=45754 - increasing maximum columns in Colin> an index from 16 to 32 This one too. ------- Agree that we should look at adding the first two ones to MariaDB too, if they make sense. I did read up on bug 44927 - auto increment counter, and still not sure if Serg or Zardosht is right. When checking the code, it looks like using HA_AUTO_PART_KEY in the engine is the right way to go. After all, this is just a check if we should allow auto_increment as a secondary part of a key. In this case there is no patch to add to MariaDB. Serg, can you please verify this. Regarding http://bugs.mysql.com/bug.php?id=45458, it would be good to use the new CREATE options we have in 5.2 to store the fact if a key is clustered or not. Serg, would you like to review the patch and see if it can go into 5.2 or 5.3 ? Regards, Monty