Re: [Maria-developers] [Commits] Rev 2835: added a sphinxse test suite in http://bazaar.launchpad.net/~maria-captains/maria/5.2/
<serg@askmonty.org> writes:
=== added file 'mysql-test/suite/sphinx/sphinx.test' --- a/mysql-test/suite/sphinx/sphinx.test 1970-01-01 00:00:00 +0000 +++ b/mysql-test/suite/sphinx/sphinx.test 2010-08-06 13:11:37 +0000 @@ -0,0 +1,30 @@ +if (`SELECT "$HAVE_SPHINX" < "0000.0009.0009"`) { + skip Need Sphinx version 0.9.9 or later; +} +if (`SELECT "$HA_SPHINX_SO" = ""`) { + skip No SphinxSE plugin; +} + +eval INSTALL PLUGIN sphinx SONAME "$HA_SPHINX_SO";
Should there be an UNINSTALL PLUGIN at the end of the test case? Otherwise I suppose following test cases could end up running with the plugin loaded (or not, at random), potentially causing .result differences. - Kristian.
Hi, Kristian! On Aug 06, Kristian Nielsen wrote:
<serg@askmonty.org> writes:
=== added file 'mysql-test/suite/sphinx/sphinx.test' --- a/mysql-test/suite/sphinx/sphinx.test 1970-01-01 00:00:00 +0000 +++ b/mysql-test/suite/sphinx/sphinx.test 2010-08-06 13:11:37 +0000 @@ -0,0 +1,30 @@ +if (`SELECT "$HAVE_SPHINX" < "0000.0009.0009"`) { + skip Need Sphinx version 0.9.9 or later; +} +if (`SELECT "$HA_SPHINX_SO" = ""`) { + skip No SphinxSE plugin; +} + +eval INSTALL PLUGIN sphinx SONAME "$HA_SPHINX_SO";
Should there be an UNINSTALL PLUGIN at the end of the test case?
Otherwise I suppose following test cases could end up running with the plugin loaded (or not, at random), potentially causing .result differences.
No, I think it cannot happen - my.cnf is different, so mtr will make sure to restart mysqld with new settings (but I didn't try to veryfy it). Anyway, uninstaling is a good thing to do, I'll add it. Thanks for notifcing! Regards, Sergei
participants (2)
-
Kristian Nielsen -
Sergei Golubchik