Re: [Maria-developers] 1d577194654: Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
Hi, Michael! On Mar 29, Michael Widenius wrote:
revision-id: 1d577194654 (mariadb-10.5.2-526-g1d577194654) parent(s): 1bbc852ef71 author: Michael Widenius <michael.widenius@gmail.com> committer: Michael Widenius <michael.widenius@gmail.com> timestamp: 2021-03-24 15:03:04 +0200 message:
Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
diff --git a/sql/item.cc b/sql/item.cc index e5be8699d80..e0ba4ff2c89 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -975,9 +975,7 @@ class Item :public Value_source, void share_name_with(const Item *item) { name= item->name; - common_flags= static_cast<uint8> - ((common_flags & ~IS_AUTO_GENERATED_NAME) | - (item->common_flags & IS_AUTO_GENERATED_NAME)); + is_autogenerated_name= item->is_autogenerated_name;
this, apparently, should be in the commit 039f4a054bb "Removed Item::common_flags and replaced it with bit fields"
}
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org
Hi! On Mon, Mar 29, 2021 at 4:20 PM Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Michael!
Only people who do not know me calls me Michael... Who are you?
Revert MDEV-16592 "Change Item::with_sum_func to a virtual method"
diff --git a/sql/item.cc b/sql/item.cc index e5be8699d80..e0ba4ff2c89 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -975,9 +975,7 @@ class Item :public Value_source, void share_name_with(const Item *item) { name= item->name; - common_flags= static_cast<uint8> - ((common_flags & ~IS_AUTO_GENERATED_NAME) | - (item->common_flags & IS_AUTO_GENERATED_NAME)); + is_autogenerated_name= item->is_autogenerated_name;
this, apparently, should be in the commit 039f4a054bb "Removed Item::common_flags and replaced it with bit fields"
Have now done this. I assume you understand that moving a commit like this between version takes about 10-30 min and have no affect on the end result. I am happy to do that if you think it is important, but doing it over and over again is a bit waste of time that I could use for more critical items... Regards, Monty
participants (2)
-
Michael Widenius -
Sergei Golubchik