[Maria-developers] Please assign PRs that modify debian/ contents for Otto to review
Hello! While working on putting MariaDB 10.5.5 into Debian I noticed that there were a couple of commits that landed more or less on the same day as the release was made and "broke" it just before release. Now there are surprises in a stable release I need to fix and the situation puts extra strain on me. It is good that many people participate in maintaining the contents of debian/ in the MariaDB Server, because I don't have time to do everything. I would however appreciate that when changes are made, I would be given a chance to review them. I will review them post-release anyway and it would save a lot of trouble, if we can fix stuff during the development cycle and not having to patch a post-release in order to be able to put it forward to Debian/Ubuntu. So, please make PRs of any debian/ changes you make, and feel free to add me as the reviewer (or one of the reviewers). This policy can also be automated using a .github/CODEOWNERS file, so I made a PR about it at https://github.com/MariaDB/server/pull/1650 Thanks! PS. I will deliver a MariaDB 10.5 and MariaDB in Debian status talk at https://debconf20.debconf.org/talks/98-whats-new-in-mariadb-server-105-and-g... in case anybody is interested to listen in. -- Follow me at @ottokekalainen
Apologies, It was to correct some other broken things. Can I see a change log of your corrections to understand what went wrong? Totally agree that it was mostly process error and review that went wrong, so yes. PR merged. Let's do that. Nice and automated. Best wishes with the talk. On Fri, Aug 14, 2020 at 4:50 AM Otto Kekäläinen <otto@kekalainen.net> wrote:
Hello!
While working on putting MariaDB 10.5.5 into Debian I noticed that there were a couple of commits that landed more or less on the same day as the release was made and "broke" it just before release. Now there are surprises in a stable release I need to fix and the situation puts extra strain on me.
It is good that many people participate in maintaining the contents of debian/ in the MariaDB Server, because I don't have time to do everything. I would however appreciate that when changes are made, I would be given a chance to review them. I will review them post-release anyway and it would save a lot of trouble, if we can fix stuff during the development cycle and not having to patch a post-release in order to be able to put it forward to Debian/Ubuntu.
So, please make PRs of any debian/ changes you make, and feel free to add me as the reviewer (or one of the reviewers).
This policy can also be automated using a .github/CODEOWNERS file, so I made a PR about it at https://github.com/MariaDB/server/pull/1650
Thanks!
PS. I will deliver a MariaDB 10.5 and MariaDB in Debian status talk at
https://debconf20.debconf.org/talks/98-whats-new-in-mariadb-server-105-and-g... in case anybody is interested to listen in.
-- Follow me at @ottokekalainen
Hello! If you make changes to debian/*, please file a PR and mark me as a reviewer. It would save a lot of time and this could have easily been avoided: https://github.com/MariaDB/server/commit/5ca14dafbee8a1877ac30e955616e9ecea7... https://github.com/MariaDB/server/commit/e3fc9c1db04bdc5566bcdafcc3d51591990... to 13. elok. 2020 klo 21.49 Otto Kekäläinen (otto@kekalainen.net) kirjoitti:
Hello!
While working on putting MariaDB 10.5.5 into Debian I noticed that there were a couple of commits that landed more or less on the same day as the release was made and "broke" it just before release. Now there are surprises in a stable release I need to fix and the situation puts extra strain on me.
It is good that many people participate in maintaining the contents of debian/ in the MariaDB Server, because I don't have time to do everything. I would however appreciate that when changes are made, I would be given a chance to review them. I will review them post-release anyway and it would save a lot of trouble, if we can fix stuff during the development cycle and not having to patch a post-release in order to be able to put it forward to Debian/Ubuntu.
So, please make PRs of any debian/ changes you make, and feel free to add me as the reviewer (or one of the reviewers).
This policy can also be automated using a .github/CODEOWNERS file, so I made a PR about it at https://github.com/MariaDB/server/pull/1650
Thanks!
PS. I will deliver a MariaDB 10.5 and MariaDB in Debian status talk at https://debconf20.debconf.org/talks/98-whats-new-in-mariadb-server-105-and-g... in case anybody is interested to listen in.
-- Follow me at @ottokekalainen
-- Follow me at @ottokekalainen
Also, maybe people should not use as their commit email addresses that don't work?
From 5ca14dafbee8a1877ac30e955616e9ecea77fbfc Mon Sep 17 00:00:00 2001 From: Alexey Botchkov <holyfoot@askmonty.org>
--> 550 5.1.1 <holyfoot@askmonty.org>: Recipient address rejected: User unknown in virtual alias table ti 20. lokak. 2020 klo 11.55 Otto Kekäläinen (otto@kekalainen.net) kirjoitti:
Hello!
If you make changes to debian/*, please file a PR and mark me as a reviewer.
It would save a lot of time and this could have easily been avoided:
https://github.com/MariaDB/server/commit/5ca14dafbee8a1877ac30e955616e9ecea7... https://github.com/MariaDB/server/commit/e3fc9c1db04bdc5566bcdafcc3d51591990...
to 13. elok. 2020 klo 21.49 Otto Kekäläinen (otto@kekalainen.net) kirjoitti:
Hello!
While working on putting MariaDB 10.5.5 into Debian I noticed that there were a couple of commits that landed more or less on the same day as the release was made and "broke" it just before release. Now there are surprises in a stable release I need to fix and the situation puts extra strain on me.
It is good that many people participate in maintaining the contents of debian/ in the MariaDB Server, because I don't have time to do everything. I would however appreciate that when changes are made, I would be given a chance to review them. I will review them post-release anyway and it would save a lot of trouble, if we can fix stuff during the development cycle and not having to patch a post-release in order to be able to put it forward to Debian/Ubuntu.
So, please make PRs of any debian/ changes you make, and feel free to add me as the reviewer (or one of the reviewers).
This policy can also be automated using a .github/CODEOWNERS file, so I made a PR about it at https://github.com/MariaDB/server/pull/1650
Thanks!
PS. I will deliver a MariaDB 10.5 and MariaDB in Debian status talk at https://debconf20.debconf.org/talks/98-whats-new-in-mariadb-server-105-and-g... in case anybody is interested to listen in.
-- Follow me at @ottokekalainen
-- Follow me at @ottokekalainen
-- Follow me at @ottokekalainen
participants (2)
-
Daniel Black -
Otto Kekäläinen