Hi Sergei, On Sat, May 09, 2015 at 10:07:11AM +0200, Sergei Golubchik wrote:

Hi, Sergey!

On Apr 15, svoj@mariadb.org wrote:

...

revision-id: eb059cd41e5553597f81fd90ad55c07d76d317ce parent(s): ceae9ba7c8872d6558b331ef1ed1ebef42ecdc19 committer: Sergey Vojtovich branch nick: mariadb timestamp: 2015-04-15 18:32:34 +0400 message:

MDEV-8001 - mysql_reset_thd_for_next_command() takes 0.04% in OLTP RO

ok to push

...

Removed mysql_reset_thd_for_next_command(). Call THD::reset_for_next_command() directly instead.

mysql_reset_thd_for_next_command() overhead dropped 0.04% -> out of radar. THD::reset_for_next_command() overhead didn't increase.

Sure, why would it increase? In theory if THD::reset_for_next_command() was inlined into mysql_reset_thd_for_next_command() overhead of the former should increase when we eliminate the latter. But it is unlikely the case, nevertheless I though it is a good idea to mention it.

Thanks, Sergey