Hi, Holyfoot! Just one question, see below. Otherwise ok. On Sep 08, holyfoot@askmonty.org wrote:

revno: 3883 revision-id: holyfoot@askmonty.org-20130908092209-xar471jadl7lmwzo parent: sergii@pisem.net-20130907203634-htu89dqmwe5gqwy5 committer: Alexey Botchkov <holyfoot@askmonty.org> branch nick: 55-4472 timestamp: Sun 2013-09-08 14:22:09 +0500 message: MDEV-4472 Audit-plugin. Server-related part of the task. file_logger became the service. Data like query_id now are sent to the audit plugin. Fix for MDEV-4770 ported from 10.0. Fix added for the read_maria_plugin_info(). Log rotation can be disabled with 'set rotations=0'.

=== renamed file 'plugin/sql_errlog/sql_logger.cc' => 'mysys/file_logger.c' --- a/plugin/sql_errlog/sql_logger.cc 2013-06-22 12:02:03 +0000 +++ b/mysys/file_logger.c 2013-09-08 09:22:09 +0000 @@ -16,7 +16,7 @@

#include "my_global.h" #include <my_sys.h> -#include "service_logger.h" +#include <mysql/service_logger.h> #include <my_pthread.h>

extern MYSQL_PLUGIN_IMPORT char *mysql_data_home;

I believe we agreed to keep file_logger.c completely clean from dynamic-plugin-related code. Did you forget to remove the line above? Regards, Sergei