Hi, Michael! I did not get any reply to my email From: Sergei Golubchik <serg@mariadb.org> To: Michael Widenius <michael.widenius@gmail.com> Cc: maria-developers@lists.launchpad.net Subject: Re: bf8bd057344: MDEV-23001 Precreate static Item_bool() to simplify code Date: Tue, 8 Sep 2020 20:39:35 +0200 and I don't see any related changes in this commit. Please, do at least one of the two. Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org On Dec 03, Michael Widenius wrote:
revision-id: 32104b969513 (mariadb-10.5.2-267-g32104b969513) parent(s): 32a29afea777 author: Michael Widenius <michael.widenius@gmail.com> committer: Michael Widenius <michael.widenius@gmail.com> timestamp: 2020-09-17 12:24:45 +0300 message:
MDEV-23001 Precreate static Item_bool() to simplify code
The following changes where done: - Create global Item: Item_false and Item_true - Replace all creation if 'FALSE' and 'TRUE' top level items used for WHERE/HAVING/ON clauses to use Item_false and Item_true.
The benefit are: - Less and faster code - No test needed if we where able to create the new item. - Fixed possible errors if 'new' would have failed for the Item_bool's