Hi, Aleksey! Feel free to remove it. It there are compilers that don't support long long nowadays, MariaDB wouldn't compile there anyway. On Jul 20, Aleksey Midenkov wrote:
Do we need HAVE_LONG_LONG in item.cc:
#ifdef HAVE_LONG_LONG case MYSQL_TYPE_LONGLONG: field= new (mem_root) Field_longlong((uchar*) 0, max_length, null_ptr, 0, Field::NONE, name, 0, unsigned_flag); break; #endif
?
There is no such check in field.cc:
case MYSQL_TYPE_LONGLONG: return new (mem_root) Field_longlong(ptr,field_length,null_pos,null_bit, unireg_check, field_name, f_is_zerofill(pack_flag) != 0, f_is_dec(pack_flag) == 0);
Regards, Sergei Chief Architect MariaDB and security@mariadb.org