Hi, Kristian! On Dec 04, Kristian Nielsen wrote:
Hi Serg,
Here is my review of your MDEV-5115 patch.
Unfortunately, I've just found this your reply. In Gmail's spam folder :( No idea why it was sorted there. That's for the review, I'll fix all comments and tests as you mentioned!
@@ -677,6 +681,20 @@ enum Log_event_type HEARTBEAT_LOG_EVENT= 27,
/* + In some situations, it is necessary to send over ignorable + data to the slave: data that a slave can handle in case there + is code for handling it, but which can be ignored if it is not + recognized. + */ + IGNORABLE_LOG_EVENT= 28, + ROWS_QUERY_LOG_EVENT= 29,
Add a comment that these are MySQL 5.6 events that are unimplemented in MariaDB.
(Do we need another MDEV to be able to replicate against a MySQL master that produces ROWS_QUERY_LOG_EVENT? It is quite similar to our ANNOTATE_ROWS_EVENT, IIRC).
Yes, similar. I'll ask Elena to try that too, we'll see. Regards, Sergei