Hi, Sergey! On Jul 03, Sergey Vojtovich wrote:
Hi, Sergei!
On Tue, Jul 03, 2018 at 07:53:39PM +0200, Sergei Golubchik wrote:
Hi, Sergey!
Current status is: all staging builders pass, except for Ubuntu Precise.
But we no longer build on precise, do we? Not anymore. Though, as discussed before, it also fails to build on labrador and my push to bb-10.4-release was built only on few platforms.
labrador already fails to build 10.3 (and other branched?) with internal compiler error. we'll get a newer mac.
Any followup MDEVs after this one is pushed? Like migrate atomics ops to C++11 or something? No MDEVs, but it should happen eventually. I'd like to wait a bit with implementing this (may be till first release) so that we're more or less certain we won't have to revert it.
right. my question was more about getting an idea of *what* should happen eventually. I didn't mean it should happen now.
+ ENDIF() +ELSE() + SET(CMAKE_CXX_STANDARD 11)
I'd expect this to mean c++11, not gnu++11. I see your point. We should change the above to c++11 as well to be consistent.
Also, note that rocksdb, tokudb, and aws plugin all use c++11, no plugin uses gnu++11.
diff --git a/storage/tokudb/PerconaFT/portability/toku_crash.cc b/storage/tokudb/PerconaFT/portability/toku_crash.cc index 0af85342a99..297cc29d9ca 100644 --- a/storage/tokudb/PerconaFT/portability/toku_crash.cc +++ b/storage/tokudb/PerconaFT/portability/toku_crash.cc @@ -70,7 +70,7 @@ run_gdb(pid_t parent_pid, const char *gdb_path) { "-ex", "thread apply all bt", "-ex", "thread apply all bt full", exe_buf, pid_buf, - NULL); + (char*) NULL);
Why's that? storage/tokudb/PerconaFT/portability/toku_crash.cc: In function ‘void run_gdb(pid_t, const char*)’: storage/tokudb/PerconaFT/portability/toku_crash.cc:73:16: error: missing sentinel in function call [-Werror=format=] NULL); ^
interesting. ok. Regards, Sergei Chief Architect MariaDB and security@mariadb.org