Re: [Maria-developers] MDEV-11780 Crash with PREPARE + SP out parameter + literal

Hi, Alexander! On Jan 20, Alexander Barkov wrote:

Hello Sergei,

Please review a patch for MDEV-11780.

Thanks!

commit 1e6544808b1da0ca76d6c2e72318f41eeeb037a7 Author: Alexander Barkov <bar@mariadb.org> Date: Fri Jan 20 14:20:52 2017 +0400

MDEV-11780 Crash with PREPARE + SP out parameter + literal

A bit more of a comment would've been nice here. I don't understand what's going on, why the crash. So, for EXECUTE stmt USING 10; it calls set_from_item. Literal or not, It doesn't change the fact that Item_param itself is a Settable_routine_parameter. So, why does it crash in Protocol_text::send_out_parameters? Regards, Sergei Chief Architect MariaDB and security@mariadb.org