Hi, Tan Tran. Your patch is quite correct. I just don't think the 'internal_stop_logging' and 'mark_always_logged' lines are superfluous in this case. And there are 2 more variables that don't effectively change it's value until restart logging. So i modified the patch with all that, it's here if you're interested: http://lists.askmonty.org/pipermail/commits/2014-March/006008.html Thanks for your help. HF 10.03.2014 9:07, Tan Tran wrote:
Hi maria-developers,
This is my patch for MDEV-5681: "audit log will not rotate when the file size exceeds global variable setting":
http://bazaar.launchpad.net/~tktran/maria/maria-fix-bug5681/revision/4102 http://bazaar.launchpad.net/%7Etktran/maria/maria-fix-bug5681/revision/4102
To test,
1. set server_audit_events = 'connect' and keep default rotate size of 1000000. 2. connect with a bad password about 20 times: for i in {1..20}; do mysql -ufail -pfail; done 3. see that server_audit.log is X bytes 4. set server_audit_rotate_size = 1000 5. connect with bad password for another 20 times 6. see original server_audit.log is still X bytes (meaning log rotated immediately) and subsequent server_audit.log.* logs are ~1000 bytes or less
Please review.
Thanks, Tan Tran Prospective GSoC student
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp