Hi, Oleksandr, Ok to push after fixing spagetty (either by fixing a typo or by changing the code pattern as suggested below). On Jan 25, Oleksandr Byelkin wrote:
revision-id: 6a4b85ce1cc (mariadb-10.5.27-202-g6a4b85ce1cc) parent(s): d261fa5c703 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2025-01-24 17:24:17 +0100 message:
MDEV-20281 "[ERROR] Failed to write to mysql.slow_log:" without error reason
Add "backup" (in case of absence issued by error) reasons for failed logging.
@@ -998,6 +1047,9 @@ bool Log_to_csv_event_handler:: close_log_table(thd, &open_tables_backup); thd->time_zone_used= save_time_zone_used; DBUG_RETURN(result); +store_err: // spagetty, but reduce size of the code + cause= "Can't write data (possible incorrect log table structure)"; + goto err; }
typo. it's "spaghetti" but may be better to avoid it altogether by rewriting as cause= "..."; if (field[0]->store(...)) goto err; if (field[1]->store(...)) goto err; if (field[2]->store(...)) goto err; ... cause= NULL; Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org