Re: [Maria-developers] MDEV-5674 - Performance: my_hash_sort_bin is called too often

Hi Segei, sorry for the mess with revisions and incorrect MDEV specification. The proper patch is: Date: Fri, 14 Feb 2014 12:25:50 +0000 (UTC) From: Sergey Vojtovich To: commits@mariadb.org Subject: [Commits] Rev 4006: MDEV-5674 - Performance: my_hash_sort_bin is called too often in lp:maria/10.0 Thanks, Sergey On Tue, Mar 04, 2014 at 12:21:24PM +0100, Sergei Golubchik wrote:

Hi, Sergey!

On Mar 03, Sergey Vojtovich wrote:

...

Hi Sergei,

thanks for your comments. Did you also review the first patch? revno: 4009 committer: Sergey Vojtovich branch nick: 10.0 timestamp: Fri 2014-02-14 16:25:41 +0400 message: MDEV-5674 - Performance: my_hash_sort_bin is called too often

- reduced number of my_hash_sort_bin() calls from 4 to 2 per query. Let MDL subsystem use pre-calculated hash value for hash inserts and deletes. - reduced number of memory accesses done by my_hash_sort_bin()

No. I thought there's only one, and reviewed the last as usual. Now I've looked for it and couldn't find this patch. There were few revno:4009 mail, but none about my_hash_sort_bin. And few "MDEV-5674" (really MDEV-5675), but none with revno:4009.

Regards, Sergei