Hi, Oleksandr, On Jul 18, Oleksandr Byelkin wrote:
On Tue, Jul 18, 2023 at 11:23 AM Sergei Golubchik wrote:
But is it all necessary to show the bug? may be a test case could be much simpler?
I just rely on Elena, but if you think it is worth it I can spend more time studying the test case...
May be you can ask Elena to help with that? Anyway, this test is so complex that if it'll start failing it'll be very difficult to understand why. I don't even understand what it's doing and how it's relevant to the fix and slow log (I believe it is relevant and that it fails without the fix, I just don't see why and how). I don't think it should be pushed as is, better to have no test case at all (other tests will detect data type change anyway).
On Jul 17, Oleksandr Byelkin wrote:
Sergei Golubchik <serg@mariadb.org> schrieb
The patch is ok, but the test case is rather weird. What does it do?
Magic (I don't digged deep, because it is very fast).
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org