Hi Serg, This is review input for commit 8fb54fa006367e3a9cbe32dc1734c980cc5d5096. Item #1: I've tried adding some tests and neither of them fails. Can you check what's going on? I'm attaching the patch with tests to this email. Item #2: please improve the commit comment as was requested in my previous e-mail: On Thu, Oct 28, 2021 at 04:58:35PM +0300, Sergey Petrunia wrote:
First, input on the commit comment. Please consider it as a request applying to ALL further commits to the MariaDB codebase.
MDEV-23766: implemented requested debug checks
Imagine somebody looking at this in a few years. Will they know what checks were requested? They might get a clue by looking at the Jira text, but the idea to make the commit comments concise and self-contained descriptions.
Something like this:
Line #1: one-line description of the patch:
MDEV-23766: Make attempts to write invalid JSON cause assertion failures
Subsequent lines:
Make JSON writing API (class Json_writer) check the produced JSON document is valid. The following checks are made: - JSON objects must contain named members - JSON arrays must contain unnamed members. - (TODO: add other restrictions we're enforcing).
BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://petrunia.net