Wlad, If I may, I'd like to point out that both grep and tail are very easily, and readily implemented in python as well, which is equally portable and increasingly common to have installed on windows workstations (I use it on servers professionally for admin type tasks, etc). Also it is packaged in a very standard, easy to use (and to be located during build time) manner that would be amazingly straightforward as a dependency. Furthermore you can easily make a portable, directory with a path (just set the PYTHON_PATH) type installation for all build environments which don't have it or don't want it for anything outside of this use. If we are making use of what is already in existence, why not try to make use of what may already even be installed. Jakob Lorberblatt
Kristian, this patch fails on Windows builds due to "grep" and "tail" used in the test cases. http://buildbot.askmonty.org/buildbot/builders/win2008r2-vs2010-amd64-debug/ builds/181
Perhaps it could be a good idea to rewrite the case in a portable way, for example using "perl; "sections ? Hopefully, grep and tail will only take a few lines of Perl.
Thanks, Wlad
-----Original Message----- From: maria-developers- bounces+wlad=montyprogram.com@lists.launchpad.net [mailto:maria- developers-bounces+wlad=montyprogram.com@lists.launchpad.net] On Behalf Of Kristian Nielsen Sent: Montag, 4. April 2011 09:29 To: monty@askmonty.org Cc: maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] [Commits] Rev 2864: MWL#136: Cross- engine consistency for START TRANSACTION WITH CONSISTENT SNAPSHOT in http://bazaar.launchpad.net/~maria-captains/maria/5.1
Hi Monty!
Thanks for review of MWL#136.
I fixed the patch according to all your suggestions!
- Kristian.
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp