Hi, Sergey! On Mar 24, Sergey Vojtovich wrote:
This is second list of questions I came up while merging test cases: - --ignore-builtin-innodb is deprecated in 5.6, do we want to deprecate it too?
No, of course not. It was introduced in 5.1 so that one could load the engine from storage/innodb_plugin instead of the compiled-in engine from storage/innobase. The tree had two versions of innodb. Now MySQL has only one version of InnoDB, this switch can only be used to load XtraDB instead. But MariaDB is shipped with both XtraDB and InnoDB, and we want our users to have a choice, they need --ignore-builtin-innodb.
- LOW_PRIORITY WRITE is deprecate in 5.6, do we want to deprecate it too?
Yes, I think so. LOCK TABLE ... LOW_PRIORITY WRITE is exactly identical to LOCK TABLE ... WRITE, "LOW_PRIORITY" is ignored basically since MDLs were introduced.
The following items seem to be not merged to MariaDB. Do we want to merge them? WL#5331 Support Unicode for Windows command line client
MDEV-4118
Bug#12688860 : SECURITY RECOMMENDATION: PASSWORDS ON CLI
I don't know. Looks annoying to me. And it doesn't help anyway - remember how many bug reports we've got like "MYSQLD DOESN'T START, IT ONLY PRINTS `Fatal error: Please read Security section of the manual to find out how to run mysqld as root!' WHAT SHOULD I DO?"
WL#5855 (EXPLAIN FORMAT=JSON) partition test
what do you mean?
WL#5980 - Allow remote tablespaces (need to check)
it's a support for DATA DIRECTORY in InnoDB please create a jira issue for 10.1.
WL5602 Providing password hashing with appropriate strength
No, that's badly implemented support for SHA256 password hashing. We might want to do it - properly - if there will be a convincing reason to.
Bug#12316645: Wrong cost calculation with optimizer_join_cache_level settings
It comes with test cases. Do they pass? Fail? I suppose you can create a Jira issue for that, like you did for other bugs.
WL#5602 - SHA256 password authentication
See above.
Bugs#12635232: VALGRIND WARNINGS: IS_IPV6, IS_IPV4, INET6_ATON, INET6_NTOA + MULTIBYTE CHARSET Bug#14040277 UNINITIALIZED VALUE REFERENCED IN STR_TO_IPV6 And a lot of other IPV6 related stuff.
Please create a jira task for 10.1 (adding ipv6/ipv4 functions like in 5.6). Unless we have it already, there are few ipv6-related tasks. Regards, Sergei