
12 Jan
2017
12 Jan
'17
10:45 p.m.
Hi Alexander! Ok to push this one. I really like how this splits the function. Please put a comment that collation does not make sense (and thus is no concern) for numerical type handlers in the function where you compare them by pointer address. Also, Item_get_cache should be on a separate line. In this patch it ends up being one long line: + Item *source_expr, Item *source_const) const; Item_cache *Item_get_cache(THD *thd, const Item *item) const; Regards, Vicentiu On Sat, 10 Dec 2016 at 18:20 Alexander Barkov <bar@mariadb.org> wrote:
Forgot to attach the patch in the previous letter.
On 12/10/2016 08:17 PM, Alexander Barkov wrote:
Hello Vicențiu,
can you please review a patch for MDEV-9522 ?
Thanks!