26 Feb
2024
26 Feb
'24
1:39 p.m.
Hi, Alexander, On Feb 26, Alexander Barkov wrote:
A suggestion, rename Column_definition_implicit_upgrade(). You've changed its semantics, it's good to make sure that the code using old Column_definition_implicit_upgrade() (added e.g. in 10.6 and merged up) won't compile.
This is a good idea.
Do you have ideas about the new name?
I'm thinking of these two names:
Column_definition_implicitly_upgrade()
Column_definition_upgrade_implicitly()
Whatever you prefer. I also in these cases either swap words or alter one word slightly, something like that. Changing the order of arguments could also work, but not in this case, obviously. Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org