Hi, Sergey! On Dec 29, Sergey Vojtovich wrote:
Uhm, I don't know. I believe the point was not to treat fill_help_tables failure as fatal.
To keep this logic you can merge maria_add_gis_sp and fill_help_tables in one mysqld_install_cmd_line invocation. But that's all.
On the other hand, perhaps it's not important to preserve this logic? Then your patch is fine...
Yes, I noticed that fill_help_tables failure wasn't considered fatal same for GIS extension. But how can they possibly fail? Wrong SQL? Then we should fix it. Generic errors will most probably be caught earlier.
Right, I failed to find a reason either. May be "disk full"? But I'd rather treat it as a fatal failure.
I failed to find good reason to preserve that logic.
Okay, then feel free to push. Regards, Sergei Chief Architect MariaDB and security@mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/maria... https://www.percona.com/live/data-performance-conference-2016/sessions/maria...