Re: [Maria-developers] MDEV-9217 Split Item::tmp_table_field_from_field_type() into virtual methods in Type_handler

Hi, Alexander! Am 23.04.2017 um 22:39 schrieb Alexander Barkov:

Hello Sanja,

Monty has pushed his patch changing Item::name and Field::field_name to LEX_CSTRING.

I have adjusted my patch accordingly.

On 04/21/2017 11:33 PM, Alexander Barkov wrote:

...

Hello Sanja,

I wrote extended commit comments for the patch, to make review easier.

Please find attached.

Thanks.

On 04/21/2017 08:05 PM, Alexander Barkov wrote:

...

Hello Sanja,

Please review a patch for MDEV-9217.

Thanks!

OK to push, after changes of constant and running all tests.