On Tue, 8 Aug 2023 at 22:35, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Nikita,
On Jul 25, Nikita Malyavin wrote:
Regarding MDEV-31646 preserve DMLs in case of online binlog fault: It's changes are shown there as a part of ca64ddcc709, but it's important to point out that it's a separate thing: It is the commit that introduces error reporting to the ALTER thread, and its practically important only for a 32-bit build. I made it, but not sure if it's worth it. It complicates the architecture and brings many ad-hoc checks into the code.
What do you think?
let's drop this code then, please create a new MDEV about IO_CACHE on 32-bit.
And by the way, it's only applicable to systems with SIZEOF_OFF_T=4. I didn't know that when I wrote the response yet. Makes even more sense thus. The rest of the comments are obsolete then. -- Yours truly, Nikita Malyavin