andrei.elkin@pp.inet.fi writes:
Howdy Kristian,
--connection master set global binlog_alter_two_phase=true; # ... ALTER TABLE t1 DROP PRIMARY KEY; ALTER TABLE t1 ADD UNIQUE KEY ui (i); ALTER TABLE t1 ADD PRIMARY KEY (i);
Note the set *global* binlog_alter_two_phase. This will not affect the testcase at all, as the ALTER TABLE queries are using the *session* value (which defaults to false).
After looking into the test to find a reference to MDEV-22985 it got clear to me that the test simply copied the description's test. Just in case I verified it to hit the assert (against the reported commit sha naturally).
Ok, cool, thanks for checking Andrei. I was just confused to see what looked like an attempt to run the test with binlog_later_two_phase=true, while in reality it was run with =false. Good to know that all is as it should be. - Kristian.