Pavel Ivanov <pivanof@google.com> writes:
Why not change Format_description_log_event::write()? It seems actually that it will be more correct if we change it. I made the following change (line numbers may be off) and it worked:
Agree, that sounds like a good idea, thanks!
If you are interested in helping with testing this, I can write a patch later, but I need a way to test it without having to spend unreasonable amounts of time on it.
Sure, I'll be happy to test.
Ok, great. Attached is a new patch for this. It makes mysql_binlog_send() and gtid_state_from_pos() construct the Format_description_log_event and pass it to Gtid_log_event::peek() and Gtid_list_log_event() to get the correct (I hope) common_header_length. The patch also includes my original patch for outputting the master's Format_description event during slave reconnect, fixed with out suggested changes. - Kristian.