Hi, Holyfoot! On Nov 30, holyfoot@askmonty.org wrote:
At file:///home/hf/wmar/mdev-5138/
------------------------------------------------------------ revno: 3991 revision-id: holyfoot@askmonty.org-20131130132432-etlmes8qhhqhr1iu parent: elenst@wheezy-64.home-20131128160251-vn857wx5qlon6j1p committer: Alexey Botchkov <holyfoot@askmonty.org> branch nick: mdev-5138 timestamp: Sat 2013-11-30 17:24:32 +0400 message: MDEV-5138 Numerous test failures in "mtr --ps --embedded". The function Protocol::net_store_data(a, b, CHARSET_A, CHARSET_B) should be adapted to be working in the embedded server as it's done with the Protocol::net_store_data(a, b). That new function renamed as net_store_data_cs, so we can make it virtual.
Why does Protocol::net_store_data() have to be virtual? (if it doesn't, Protocol::net_store_data_cs doesn't have to be virtual either and doesn't have to be renamed) Regards, Sergei