On Fri, Mar 19, 2021 at 11:24 AM Elena Stepanova <elenst@mariadb.com> wrote:
Hi Otto,

On 3/18/21 8:50 AM, Otto Kekäläinen wrote:
> Hello!
>
> I noticed there are quite a lot of upgrade test failures on the 10.5
> branch, which is a stable release and should definitely be all green
> all the time.
>
> Here is quick review of those issues with suggested fixes. Maybe
> Daniel or Elena can do them?
>
> They are all easy ones and would make 7 currently red CI steps turn into green.
>
>
> ## Overview:
> http://buildbot.askmonty.org/buildbot/grid?branch=10.5&category=main&category=experimental
>
> ## kvm-deb-buster-amd6 minor-upgrade-all
> (http://buildbot.askmonty.org/buildbot/builders/kvm-deb-buster-amd64/builds/3995/steps/minor-upgrade-all/logs/stdio):
>
> ++ diff -U1000 /home/buildbot/mariadb.org-tools-master/buildbot/baselines/ldd.10.5.buster.amd64
> /home/buildbot/ldd.new
> --- /home/buildbot/mariadb.org-tools-master/buildbot/baselines/ldd.10.5.buster.amd64
> 2021-03-16 21:03:04.000000000 -0400
> +++ /home/buildbot/ldd.new 2021-03-17 17:23:42.066634818 -0400
> - liblz4.so.1 => /usr/lib/x86_64-linux-gnu/liblz4.so.1
>
> Seems some dependency stopped including liblz4. This didn't affect
> MariaDB. This is a valid change and the fix is to "reset" the
> ldd.10.5.buster.amd64 file on buildbot.askmonty.org so that there
> would be no diff no more.
>

It says that ha_mroonga.so which was linking with liblz4 isn't anymore.
I don't know why it happened, and maybe it's legit this time, but this
is exactly the situation for which this whole check was added, and
mroonga seems to have a lot of code related to lz4; so I will need
someone's (probably Sergei's) confirmation that it's expected before I
change the baseline. Or maybe Daniel knows why it has happened, that
will also be sufficient.

I did a brief look yesterday. It seems parts of mroonga are configured to use lz4.

So it seems like a legitimate failure, however I haven't looked at why it stopped finding /linking against it.