Hi! On Tue, Apr 22, 2025 at 5:32 PM Sergei Golubchik <serg@mariadb.org> wrote:
MDEV-36536 Add option to not collect statistics for long char/varchars
<cut>
perl; # Variables which we don't want to display in the result file since - # their paths may vary: + # their paths may vary or they may use a default of 4294967295 :
why? what's wrong with 4294967295?
mysqld--help converts 4294967295 to MAX_ULONGLONG, which is wrong in this case. I prefer to not have the wrong thing in the result file. <cut>
index 69b021cd41d..aac433181a4 100644 --- a/sql/sql_class.h +++ b/sql/sql_class.h @@ -731,6 +731,7 @@ typedef struct system_variables ha_rows select_limit; ha_rows max_join_size; ha_rows expensive_subquery_limit; + ulong analyze_max_length;
don't use ulong, please. uint or ulonglong.
Why? We have a lot of other ulong variables. As this variable should never be bigger than UINTMAX32, ulong is the right choice. <cut>
+ +static Sys_var_ulong Sys_analyze_max_length( + "analyze_max_length", + "Fields that require more storage than analyze_max_length and are not "
better "Fields which length in bytes more than this are skipped by ANALYZE TABLE PERSISTENT unless explicitly listed in the FOR COLUMNS () clause"
"require more storage" is not very clear
I thought more storage would be clear. Will change to your suggestion. Regards, Monty