Hi, Jan! On Aug 20, Jan Lindström wrote:
Serg,
Could you please review fix for MDEC-4923, where these changes are pushed lp:maria/5.5 or lp:~maria-captains/maria/5.5 ?
Looks correct. This seems to be XtraDB bug. lp:maria/5.5 is an alias for lp:~maria-captains/maria/5.5
=== modified file 'storage/xtradb/os/os0file.c' --- storage/xtradb/os/os0file.c 2013-07-29 14:03:41 +0000 +++ storage/xtradb/os/os0file.c 2013-08-20 05:35:22 +0000 @@ -1658,8 +1658,8 @@ } }
- if (srv_use_atomic_writes && type == OS_DATA_FILE && - os_file_set_atomic_writes(file, name)) { + if (srv_use_atomic_writes && type == OS_DATA_FILE && + !os_file_set_atomic_writes(file, name)) { CloseHandle(file); *success = FALSE; file = INVALID_HANDLE_VALUE; @@ -1786,7 +1786,7 @@ #endif /* USE_FILE_LOCK */
if (srv_use_atomic_writes && type == OS_DATA_FILE - && os_file_set_atomic_writes(name, file)) { + && !os_file_set_atomic_writes(name, file)) {
*success = FALSE; close(file);
Regards, Sergei