Hi Sergey,

Thanks for the review. I would push the fix into 5.5 if there are no buildbot failures. There seems to be something wrong with solaris though. Need to #ifdef the __sync_synchronize() there. The patch generally applies to 5.5 as well.

Since we're having a 5.5 week next, I'll test it for 5.5 as well, then push.

Vicentiu

On Tue, 2 Aug 2016 at 13:47 Sergey Vojtovich <svoj@mariadb.org> wrote:
Hi Vicentiu,

Ok to push. This patch is against 10.2, do you plan to fix previous versions
separately?

On Mon, Aug 01, 2016 at 02:46:03PM +0300, vicentiu wrote:
> revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 (mariadb-10.2.1-9-g5486f34)
> parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842481
> author: Vicențiu Ciorbaru
> committer: Vicențiu Ciorbaru
> timestamp: 2016-08-01 14:43:41 +0300
> message:
>
> MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func
>
> Fix memory barrier issues on releasing mutexes. We must have
Looks like a cutted comment.

>
> ---
>  storage/innobase/include/os0sync.h    | 17 ++++++++---------
>  storage/innobase/include/sync0sync.ic |  2 ++
>  storage/xtradb/include/os0sync.h      | 16 ++++++++--------
>  storage/xtradb/include/sync0sync.ic   |  2 ++
>  4 files changed, 20 insertions(+), 17 deletions(-)

Thanks,
Sergey

_______________________________________________
Mailing list: https://launchpad.net/~maria-developers
Post to     : maria-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~maria-developers
More help   : https://help.launchpad.net/ListHelp