Re: [Maria-developers] compilation failure: my_atomic.h

Hello Sergey, Marko, Daniel, Sergey, Marko, thanks for the explanation! Daniel, can we remove CentOS 5 buildbot machines from 10.3 ? Thanks! On 04/08/2017 05:35 AM, Sergey Vojtovich wrote:

Hi Alexander, Marko,

It was agreed to drop support for x86 asm based atomic operations in 10.3, which broke builds on this host. CentOS 5 is currently discontinued. We just need to remove it from our 10.3 builds.

We're heading towards C11 atomic operations in a sense that we mimic it's API. But we never use them as such yet due to limited availability.

Regards, Sergey

On Fri, Apr 07, 2017 at 11:17:58PM +0300, Marko Mäkelä wrote:

...

As far as I remember, didn’t we agree to drop CentOS 5 from the list of MariaDB 10.3 platforms, so that 10.3 can use C++11 across the board? C++11 would introduce the data type template std::atomic.

Marko

On Fri, Apr 7, 2017 at 10:25 PM, Alexander Barkov wrote:

...

Серега,

On 04/07/2017 09:21 PM, Alexander Barkov wrote:

...

Hi Sergey,

kvm-bintar-centos5-x86 fails to compile:

http://buildbot.askmonty.org/buildbot/grid?category=main&branch=10.3

with this error:

/home/buildbot/buildbot/build/include/my_atomic.h:121:2: error: #error atomic ops for this platform are not implemented

Can you please fix this?

<cut>