[Maria-developers] 10.2.10 compiler warnings Fedora 26 / GCC7

1 Nov 2017


      maybe worth to take a look

[  8%] Building C object 
libmariadb/mariadb_config/CMakeFiles/mariadb_config.dir/mariadb_config.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/mariadb_config/mariadb_config.c:9:49: 
warning: backslash and newline separated by space
  #define LIBS    "-L/usr/lib64/mysql/ -lmariadb "\

[ 20%] Building C object 
libmariadb/libmariadb/CMakeFiles/mariadb_obj.dir/ma_dtoa.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c: 
In function 'dtoa':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c:1465:14: 
warning: this statement may fall through [-Wimplicit-fallthrough=]
      leftright= 0;
      ~~~~~~~~~^~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c:1467:3: 
note: here
    case 4:
    ^~~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c:1473:14: 
warning: this statement may fall through [-Wimplicit-fallthrough=]
      leftright= 0;
      ~~~~~~~~~^~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c:1475:3: 
note: here
    case 5:
    ^~~~
At top level:
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/ma_dtoa.c:1161:21: 
warning: 'tinytens' defined but not used [-Wunused-const-variable=]
  static const double tinytens[]=
                      ^~~~~~~~

[ 24%] Building C object strings/CMakeFiles/strings.dir/dtoa.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/mariadb_dyncol.c: 
In function 'mariadb_dyncol_val_double':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/mariadb_dyncol.c:4049:15: 
warning: argument 1 null where non-null expected [-Wnonnull]
          *dbl= strtod(str, &end);
                ^~~~~~~~~~~~~~~~~
In file included from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/include/ma_global.h:168:0,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/libmariadb/libmariadb/mariadb_dyncol.c:64:
/usr/include/stdlib.h:126:15: note: in a call to function 'strtod' 
declared here
  extern double strtod (const char *__restrict __nptr,

[ 33%] Building C object mysys/CMakeFiles/mysys.dir/my_malloc.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/mysys/my_lib.c: In 
function 'my_dir':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/mysys/my_lib.c:144:3: 
warning: 'readdir_r' is deprecated [-Wdeprecated-declarations]
    while (!(READDIR(dirp,(struct dirent*) dirent_tmp,dp)))
    ^~~~~
In file included from /usr/include/features.h:410:0,
                  from /usr/include/pthread.h:21,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_global.h:278,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/mysys/mysys_priv.h:19,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/mysys/my_lib.c:19:
/usr/include/dirent.h:189:12: note: declared here
  extern int __REDIRECT (readdir_r,

[ 68%] Building C object storage/maria/CMakeFiles/aria.dir/ma_check.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/myisamchk.c: 
In function 'myisamchk':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/myisamchk.c:1411:22: 
warning: '%ld' directive writing between 1 and 10 bytes into a region of 
size 8 [-Wformat-overflow=]
     sprintf(null_pos,"%ld",(long) keyseg->null_pos+1);
                       ^~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/myisamchk.c:1411:21: 
note: directive argument in the range [1, 4294967296]
     sprintf(null_pos,"%ld",(long) keyseg->null_pos+1);
                      ^~~~~
In file included from /usr/include/stdio.h:939:0,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_global.h:322,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_base.h:23,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/myisam.h:26,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/myisamdef.h:20,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/fulltext.h:21,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/myisamchk.c:18:
/usr/include/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output 
between 2 and 11 bytes into a destination of size 8
    return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ 68%] Building C object storage/maria/CMakeFiles/aria.dir/ma_preload.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/mi_test3.c: 
In function 'test_write':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/mi_test3.c:367:30: 
warning: '%7ld' directive writing between 7 and 11 bytes into a region 
of size 8 [-Wformat-overflow=]
    sprintf((char*) record.id,"%7ld",(long) getpid());
                               ^~~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/mi_test3.c:367:29: 
note: directive argument in the range [-2147483648, 2147483647]
    sprintf((char*) record.id,"%7ld",(long) getpid());
                              ^~~~~~
In file included from /usr/include/stdio.h:939:0,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_global.h:322,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_base.h:23,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/myisam.h:26,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/myisam/mi_test3.c:20:
/usr/include/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output 
between 8 and 12 bytes into a destination of size 8
    return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ 71%] Building C object storage/maria/CMakeFiles/aria_chk.dir/maria_chk.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_chk.c: 
In function 'maria_chk':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_chk.c:1703:22: 
warning: '%ld' directive writing between 1 and 10 bytes into a region of 
size 8 [-Wformat-overflow=]
     sprintf(null_pos,"%ld",(long) keyseg->null_pos+1);
                       ^~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_chk.c:1703:21: 
note: directive argument in the range [1, 4294967296]
     sprintf(null_pos,"%ld",(long) keyseg->null_pos+1);
                      ^~~~~
In file included from /usr/include/stdio.h:939:0,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_global.h:322,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_base.h:23,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/maria.h:22,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_def.h:18,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/ma_fulltext.h:20,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_chk.c:18:
/usr/include/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output 
between 2 and 11 bytes into a destination of size 8
    return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ 73%] Building C object storage/maria/CMakeFiles/ma_test3.dir/ma_test3.c.o
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/ma_test3.c: 
In function 'test_write':
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/ma_test3.c:365:30: 
warning: '%7ld' directive writing between 7 and 11 bytes into a region 
of size 8 [-Wformat-overflow=]
    sprintf((char*) record.id,"%7ld", (long) getpid());
                               ^~~~
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/ma_test3.c:365:29: 
note: directive argument in the range [-2147483648, 2147483647]
    sprintf((char*) record.id,"%7ld", (long) getpid());
                              ^~~~~~
In file included from /usr/include/stdio.h:939:0,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_global.h:322,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/my_base.h:23,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/include/maria.h:22,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/maria_def.h:18,
                  from 
/home/builduser/rpmbuild/BUILD/mariadb-10.2.10/storage/maria/ma_test3.c:20:
/usr/include/bits/stdio2.h:33:10: note: '__builtin___sprintf_chk' output 
between 8 and 12 bytes into a destination of size 8
    return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Maria-developers] 10.2.10 compiler warnings Fedora 26 / GCC7

Reindl Harald