Hi, Nikita! On Jul 19, Nikita Malyavin wrote:
Hello, Sergei!
1. What you ask was done in 01ab3db8c7 "make all conversions in check() to avoid possible errors". It was mentioned in the previous discussion btw
I didn't review it, did I? All I have is 2d73406dad8: MDEV-16481: set global system_versioning_asof=sf() crashes in specific case 19aebbd1b89: MDEV-16481: set global system_versioning_asof=sf() crashes in specific case
[ I think we really should consent some more automatizing tooling to better track the discussions]
Isn't it enough to just use one tool consistently? It seems that the confusion here comes from us discussing MDEV-16481 somewhere else, not in the email. No automatic tooling would help if we bypass it and discuss somewhere else.
The commits can be found at bb-10.3-nikita-old for now.
I'll take a look
2. The email in your header is wrong, I never used it in git, and besides format=fuller shows the correct one:
Right, that's my mailmap :) It only affects where review emails are sent. Also once I was interested to count internal vs external commits, and this mailmap helped to attribute them correctly. If that's confusing I think I can use mailmapped author only as the email recipient, but inclide not-mailmapped commit into the email body.
commit 19aebbd1b89feb1482e2cdf5ddb8322f48ad4216 Author: Nikita Malyavin <nikitamalyavin@gmail.com> AuthorDate: Mon Jul 22 19:12:15 2019 +1000 Commit: Nikita Malyavin <nikitamalyavin@gmail.com> CommitDate: Tue Apr 6 21:32:43 2021 +0300
On Jul 12, Nikita Malyavin wrote:
revision-id: 19aebbd1b89 (mariadb-10.3.26-129-g19aebbd1b89) parent(s): 10c163e4a18 author: Nikita Malyavin <nikita.malyavin@mariadb.com> committer: Nikita Malyavin <nikita.malyavin@mariadb.com> timestamp: 2021-04-06 21:32:43 +0300 message:
MDEV-16481: set global system_versioning_asof=sf() crashes in specific case
Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org