Hi, Aleksey! On Apr 09, Aleksey Midenkov wrote:
+# +# MDEV-17554 Auto-create new partition for system versioned tables with history partitioned by INTERVAL/LIMIT +# +# Don't auto-create new partition on DELETE HISTORY: +create or replace table t (a int) with system versioning +partition by system_time limit 1000 auto_increment;
this looks like a hack, I think we need a dedicated syntax for that. but I couldn't think of anything good now.
ok, I see that you allow both AUTO_INCREMENT and AUTO. May be better just to use AUTO?
AUTO_INCREMENT looks more explanatory. Isn't it?
Not to me. In my opinion it looks 1) confusing 2) hackish, a.k.a. "they didn't want to introduce a new keyword, so picked an existing one that looked at least remotely relevant"
To be continued...
I've attached a proof-of-concept patch that adds a partition using fallback-and-retry mechanism of open_table(). Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org