24 Apr
2011
24 Apr
'11
1:54 a.m.
On 04/23/2011 05:26 PM, Sergey Petrunya wrote:
On Sun, Apr 24, 2011 at 03:08:12AM +0400, Sergey Petrunya wrote:
Hello Igor,
First, an overall comment: there are lots of typos/coding style violations in the patch. To reduce amount of effort spent on such things, I was just fixing them as I saw them and I'm attaching the patch with all the fixes (i.e. this patch should be applied on top of the patch that I was reviewing).
Now really with attached file.
BR Sergey
Sergey, In your diff I found only corrections for typos/phrasing. Not with all of them I agree. Nevertheless I'll fix them. I did not find any corrections of coding style violations. Do I miss anything? Regards, Igor.