Hi Andrew! On Wed, Apr 15, 2015 at 11:45 AM, Andrew W Elble <aweits@rit.edu> wrote:
Nirbhay,
We've been poking at this some more. Seems like we're retracing some steps as documented here:
https://bugs.launchpad.net/codership-mysql/+bug/1052002
My patch will need to be reverted and replaced with something else.
Yes, after fixing MDEV-7995, I realized that your patch can be reverted.
MDEV-7673 is a regression caused by a portion of the fix for MDEV-6924.
Specifically this:
in sql/sql_class.cc -> THD::binlog_query() #ifdef WITH_WSREP /* Even though wsrep only supports ROW binary log format, a user can set binlog format to STATEMENT (wsrep_forced_binlog_format). In which case the control might reach here even when binary logging (--log-bin) is not enabled. This is possible because wsrep patch partially enables binary logging by setting wsrep_emulate_binlog. */ if (mysql_bin_log.is_open()) #endif /* WITH_WSREP */
That's right, removed as part of fix for MDEV-7995.
see sql/sql_insert.cc -> select_create::binlog_show_create_table()
There are other issues here which we're still trying to track down (simultaneously running 'CREATE TABLE t1 AS SELECT SLEEP(30)' on multiple nodes is bad, for instance). I wanted to at least start the
Thanks! -- Nirbhay