Hello Jerome, The last version looks very good. Thanks!. Note, I haven't made a detailed review for sp-goto.test yet. Will reply about tests in a separate letter. On 02/08/2017 06:31 PM, jerome brauge wrote:
Hi Alexander, I'm sorry to waste your time for formatting and/or coding style issues. Is there a document that lists your best practices ?
No problem. Generally, we use MySQL coding style: https://dev.mysql.com/doc/internals/en/general-development-guidelines.html Please find coding style suggestions in the attached file. Also, please find comments inline: <cut>
Sorry, I might be not clear enough.
Please rename "sp_non_labelable_stmt" to "sp_labelable_stmt". My idea of this name was that these statements are ALLOWED to have a label, they can appear either with a label or without a label.
Btw, are there any statements in PL/SQL that cannot have a label?
Done.
The only place where Oracle doesn't accept a label is just before an end of block.
Thanks. So my original assumption about two separate rules for labelable and non-labelable statements was wrong. All statements are labelable. I'm not an Oracle expert yet, but gradually learning it :) So we don't need sp_non_labelable_stmt them. Ok. <cut> Can you please also have a look into: https://mariadb.com/kb/en/mariadb/mariadb-contributor-agreement-frequently-a... We require contributors to share the code either under terms of MCA or BSD-new licenses. Also, when we finish reviews, would it be possible to ask you to make a git pull request? We prefer to merge pull requests instead of pushing the patch on behalf of the contributor. Thanks!